Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: NWA + NWC deep linking #272
base: master
Are you sure you want to change the base?
feat: NWA + NWC deep linking #272
Changes from 1 commit
18ca376
636ad68
4be38e8
5c441e8
502e10e
ecafc6d
f1526a7
be1bb3d
1a53e5c
7207a0a
c6b1b4f
04af04c
7605e17
9d685a2
d214b69
1f25e39
3c19e9d
a71f15a
5a1b950
b6cce3a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will already have the nip47capabilities of the wallet (and
create_connection
can't also be edited so we don't even have that problem here (since we don't update the nip47capabilities and stick to the ones we got on fetching the first time)) so should we check for that here or even before so the user is not betrayed xD after all these steps?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do it as a follow-up too but I think it's good if we can show a screen for those scanning NWAs with their old Alby Go connections with a message to reconnect with their Hubs cc @stackingsaunter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@im-adithya
Sorry, I don't understand your comment here. I understand we don't need to do get_info.
But we also have this page so the user should immediately see it if their connection doesn't support it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup sorry I meant this
(unrelated to this PR) I was wondering if we should keep updating that
wallet.nwcCapabilities
on a regular basis since the user might have updated the permissions. But here we don't have to think about that since superuser permission can't be added later.Other parts in the comment you can ignore, I didn't see this unsupported screen then 😅
Check failure on line 76 in pages/settings/wallets/ConnectWallet.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we artificially delay the flow by 5 seconds, I wonder if it's too much. What is the reasoning here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was actually to finish the Tick animation lol, but this can be lesser, or do you think we should not care about the animation and switch instantly?