Fix openTab navigation to non http url (#2652)

Signed-off-by: Arun Kumar <[email protected]> Signed-off-by: Arun Kumar <[email protected]> Co-authored-by: Arun Kumar <[email protected]>
getgauge · Oct 26, 2022 · 4f4087e · 4f4087e
1 parent 8021586
commit 4f4087e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/lib/taiko.js b/lib/taiko.js
@@ -382,8 +382,7 @@ module.exports.openTab = async (targetUrl, options = {}) => {
   if (
     isString(targetUrl) &&
     targetUrl != 'about:blank' &&
-    !/^https?:\/\//i.test(targetUrl) &&
-    !/^file/i.test(targetUrl)
+    !/:\/\//i.test(targetUrl)
   ) {
     targetUrl = 'http://' + targetUrl;
   }

diff --git a/test/unit-tests/openTab.test.js b/test/unit-tests/openTab.test.js
@@ -64,6 +64,10 @@ describe('openTab', () => {
     expectedUrl = 'file://example.com';
     await taiko.openTab(expectedUrl);
     expect(actualUrl).to.equal(expectedUrl);
+
+    expectedUrl = 'chrome-extension://gjaerjgaerjeoareapoj/internalPage.html';
+    await taiko.openTab(expectedUrl);
+    expect(actualUrl).to.equal(expectedUrl);
   });
 
   it('should add protocol http:// if not given', async () => {