Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide entry label for entries field as default #7040

Open
wants to merge 3 commits into
base: v5/develop
Choose a base branch
from

Conversation

afbora
Copy link
Member

@afbora afbora commented Mar 2, 2025

Changelog

Fixes

Breaking changes

None

Docs

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add lab and/or sandbox examples (wherever helpful)
  • Add changes & docs to release notes draft in Notion

@afbora afbora added this to the 5.0.0-rc.1 milestone Mar 2, 2025
@afbora afbora requested a review from a team March 2, 2025 19:59
@afbora afbora self-assigned this Mar 2, 2025
@afbora afbora linked an issue Mar 2, 2025 that may be closed by this pull request
@distantnative
Copy link
Member

Hi @afbora, I have three two thoughts:

  • Maybe it would be even better to already prevent the field props that we don't want to support on the backend, e.g. I'd think in EntriesField::fieldProps(): https://github.com/getkirby/kirby/blob/v5/develop/src/Form/Field/EntriesField.php#L49 (or in addition to blocking them in the Vue file too)
  • Vue 3 has a breaking change where the position of v-bind will start to matter. Any prop that we want to overwrite what's applied by v-bind should follow after v-bind, not before.

@afbora
Copy link
Member Author

afbora commented Mar 2, 2025

Thank you @distantnative for the reviews. How about now? d61514d

@afbora afbora force-pushed the v5/fix/7039-hide-entries-label branch from 22a8f60 to d61514d Compare March 2, 2025 20:56
@distantnative
Copy link
Member

Looks good. Are there other options we should block as well? Maybe counter?

@afbora
Copy link
Member Author

afbora commented Mar 3, 2025

Like that 0b0bc45?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[v5] Entries Field breaks when field has label
2 participants