Print errors on nelson unit commit failures #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavinbunney
changed the title
nkg-lyft
reviewed
Mar 19, 2020
| @@ -540,7 +540,11 @@ func main() { | |||
| unitWithVersion := selectedUnitPrefix + "@" + selectedVersion | |||
|
|
|||
| if e != nil { | |||
| return cli.NewExitError("Unable to commit "+unitWithVersion+" to '"+selectedNamespace+"'. Response was:\n"+r, 1) | |||
| errors := "" | |||
There was a problem hiding this comment.
Whats going on with the indentation here. Whats the line width here.
| for _, ee := range e { | ||
| errors += fmt.Sprintf("%s\n", ee.Error()) | ||
| } | ||
| return cli.NewExitError(fmt.Sprintf("Unable to commit %s to '%s'. Response was:\n%s\nErrors:\n%s", unitWithVersion, selectedNamespace, r, errors), 1) |
There was a problem hiding this comment.
With errors, can there be an non-empty response ie "r".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an empty response is returned from Nelson, users are shown an error without any content:
This prints the errors block as part of the message. Doesn't actually fix any errors, but might help to identify if it's a timeout/other transient issue.
Fixes #22