chore(release): Add craft publish workflow #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, any push to `master` built and uploaded the action's underlying docker image to the GitHub registry under the `latest` tag. That meant, regardless of version specified in a user's workflow they'd get the latest change. The introduction of craft allows us to push versioned images to the registry and associate a release's action with that version. At the moment, this workflow does not incorporate tags for major (e.g. `v1`) and major.minor (e.g. `v1.2`). The ability to publish several git tags will probably have to be added to craft or publish directly. Closes: #129
Lms24
reviewed
Jan 29, 2025
There was a problem hiding this comment.
This sounds reasonable to me but maybe you can walk me through the changes, just to be sure I understand things correctly?
Also would you mind updating the PR description as to what images we'll publish via craft with this change? As far as I understand it'd be :latest and the full version (:1.9.0) but I might be missing something.
…images published
Lms24
approved these changes
Jan 29, 2025
Co-authored-by: Lukas Stracke <[email protected]>
Co-authored-by: Lukas Stracke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, any push to
masterbuilts and uploads the action's underlying docker image to the GitHub registry under thelatesttag. That meant, regardless of version specified in a user's workflow they'd get the latest change.The introduction of craft allows us to push versioned images to the registry and associate a release's action with that version.
At the moment, this workflow does not incorporate tags for major (e.g.
v1) and major.minor (e.g.v1.2). The ability to publish several git tags will probably have to be added to craft or publish directly.Closes: #129, #233