ref(chunks): Extract upload logic from upload_difs_chunked
#2316
+339
−320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szokeasaurusrex
commented
Dec 16, 2024
|
|
||
| /// Renders the given detail string to the command line. If the `detail` is | ||
| /// either missing or empty, the optional fallback will be used. | ||
| fn render_detail(detail: &Option<String>, fallback: Option<&str>) { |
There was a problem hiding this comment.
This &Option<String> was copied from existing code
There was a problem hiding this comment.
Will be fixed in #2317
szokeasaurusrex
force-pushed
the
szokeasaurusrex/proguard-upload-11
branch
from
3c8f73c to
fafb281
Compare
|
Note to self (reason for marking as draft): Before merging, rename variables and modify comments as needed to make any references to DIFs generic to any uploaded object |
loewenheim
approved these changes
Dec 17, 2024
The `upload_difs_chunked` function contains logic specific to uploading DIFs, in addition to logic general to chunked uploads. This change extracts the general chunked upload logic, so it can be reused for other types of chunked uploads.
Base automatically changed from
szokeasaurusrex/proguard-upload-10
to
master
December 17, 2024 20:47
szokeasaurusrex
force-pushed
the
szokeasaurusrex/proguard-upload-11
branch
from
fafb281 to
3a8b380
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
upload_difs_chunkedfunction contains logic specific to uploading DIFs, in addition to logic general to chunked uploads.This change extracts the general chunked upload logic, so it can be reused for other types of chunked uploads.
Successor of #2303