Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HackWeek - Feature Flags Support #984

Closed
wants to merge 33 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
212f896
HackWeek - feature flags
marandaneto Aug 22, 2022
4f336aa
add import
marandaneto Aug 22, 2022
d75831f
parsing of the spec
marandaneto Aug 22, 2022
14d7c9c
add type enum and rename evaluation to evaluation rule
marandaneto Aug 22, 2022
de64e1d
add feature flags dump and transform it to a map
marandaneto Aug 22, 2022
fb53a05
expose fetch feature flags api
marandaneto Aug 22, 2022
5a9f9be
add test for parsing feature flag response
marandaneto Aug 22, 2022
2cef8f6
fix dsn parsing and change request to post
marandaneto Aug 22, 2022
2381b41
add payload field
marandaneto Aug 22, 2022
c7dab0d
temp commit
marandaneto Aug 22, 2022
db85e99
added random number generator
marandaneto Aug 23, 2022
8ccccc0
add default value
marandaneto Aug 23, 2022
726b47d
add caching of feature flags
marandaneto Aug 23, 2022
4329bd1
fix
marandaneto Aug 23, 2022
264889e
fix
marandaneto Aug 23, 2022
901d883
implement fetch for flutter transport
marandaneto Aug 23, 2022
b662c62
fix get feature flag info
marandaneto Aug 24, 2022
4de969b
fixes
marandaneto Aug 24, 2022
eeab0aa
add method with generics
marandaneto Aug 24, 2022
c0b5c80
remove non used code
marandaneto Aug 24, 2022
9226546
revert mocked transport
marandaneto Aug 24, 2022
4f8507c
ref
marandaneto Aug 24, 2022
f794350
fix type check
marandaneto Aug 24, 2022
5f7505a
read traces sample rate and error traces rate automatically
marandaneto Aug 24, 2022
f93e430
add group
marandaneto Aug 25, 2022
1f323e8
fix tests
marandaneto Aug 25, 2022
14a6602
fetch feature flags on start
marandaneto Aug 25, 2022
7c6b89c
fix tests
marandaneto Aug 26, 2022
45bb842
fix broken tests
marandaneto Aug 26, 2022
c4a77ae
vendor sha1
marandaneto Aug 26, 2022
a9a9361
supress long method
marandaneto Aug 26, 2022
163ddcf
vendor Object.hashAll
marandaneto Aug 26, 2022
0fac27e
remove non used comment
marandaneto Aug 26, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tests
  • Loading branch information
marandaneto committed Aug 26, 2022
commit 7c6b89c034836a0a13ee3533cd5cbc70e887afce
4 changes: 3 additions & 1 deletion flutter/test/default_integrations_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,9 @@ void main() {
});

test('nativeSdkIntegration adds integration', () async {
_channel.setMockMethodCallHandler((MethodCall methodCall) async {});
_channel.setMockMethodCallHandler((MethodCall methodCall) async {
return {'deviceId': 'test'};
});

final integration = NativeSdkIntegration(_channel);

Expand Down
4 changes: 3 additions & 1 deletion flutter/test/native_sdk_integration_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,9 @@ void main() {
});

test('adds integration', () async {
final channel = createChannelWithCallback((call) async {});
final channel = createChannelWithCallback((call) async {
return {'deviceId': 'test'};
});
var sut = fixture.getSut(channel);

final options = createOptions();
Expand Down