Use relative path for common Gemfile #2554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2554 +/- ##
=======================================
Coverage 69.70% 69.70%
=======================================
Files 126 126
Lines 4737 4737
=======================================
Hits 3302 3302
Misses 1435 1435
|
sl0thentr0py
approved these changes
Feb 7, 2025
| @@ -31,4 +31,4 @@ elsif ruby_version >= Gem::Version.new("3.1.0") | |||
| gem "sqlite3", "~> 2.2", platform: :ruby | |||
| end | |||
|
|
|||
| eval_gemfile File.expand_path("../Gemfile", __dir__) | |||
| eval_gemfile "../Gemfile" | |||
There was a problem hiding this comment.
the last time we touched this we had a broken release.
could you make sure .scripts/batch_build.rb works without problems before merging?
There was a problem hiding this comment.
Looks like it works:
➜ sentry-ruby (solnic/update-gemfiles-for-dependabot) ruby .scripts/batch_build.rb
WARNING: description and summary are identical
WARNING: open-ended dependency on concurrent-ruby (>= 0) is not recommended
use a bounded requirement, such as "~> x.y"
WARNING: You have specified the uri:
https://github.com/getsentry/sentry-ruby
for all of the following keys:
homepage_uri
source_code_uri
Only the first one will be shown on rubygems.org
WARNING: See https://guides.rubygems.org/specification-reference/ for help
WARNING: description and summary are identical
WARNING: open-ended dependency on bigdecimal (>= 0) is not recommended
use a bounded requirement, such as "~> x.y"
WARNING: You have specified the uri:
https://github.com/getsentry/sentry-ruby/tree/5.22.4/sentry-ruby
for all of the following keys:
homepage_uri
source_code_uri
Only the first one will be shown on rubygems.org
WARNING: See https://guides.rubygems.org/specification-reference/ for help
bundle install
Bundle complete! 27 Gemfile dependencies, 83 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.
1 installed gem you directly depend on is looking for funding.
Run `bundle fund` for details
gem build sentry-ruby-core.gemspec
Successfully built RubyGem
Name: sentry-ruby-core
Version: 5.22.4
File: sentry-ruby-core-5.22.4.gem
gem build sentry-ruby.gemspec
Successfully built RubyGem
Name: sentry-ruby
Version: 5.22.4
File: sentry-ruby-5.22.4.gem
WARNING: description and summary are identical
WARNING: open-ended dependency on railties (>= 5.0) is not recommended
if railties is semantically versioned, use:
add_runtime_dependency "railties", "~> 5.0"
WARNING: You have specified the uri:
https://github.com/getsentry/sentry-ruby/tree/5.22.4/sentry-rails
for all of the following keys:
homepage_uri
source_code_uri
Only the first one will be shown on rubygems.org
WARNING: See https://guides.rubygems.org/specification-reference/ for help
bundle install
Bundle complete! 24 Gemfile dependencies, 111 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.
gem build sentry-rails.gemspec
Successfully built RubyGem
Name: sentry-rails
Version: 5.22.4
File: sentry-rails-5.22.4.gem
WARNING: description and summary are identical
WARNING: open-ended dependency on sidekiq (>= 3.0) is not recommended
if sidekiq is semantically versioned, use:
add_runtime_dependency "sidekiq", "~> 3.0"
WARNING: You have specified the uri:
https://github.com/getsentry/sentry-ruby/tree/5.22.4/sentry-sidekiq
for all of the following keys:
homepage_uri
source_code_uri
Only the first one will be shown on rubygems.org
WARNING: See https://guides.rubygems.org/specification-reference/ for help
bundle install
Fetching gem metadata from https://rubygems.org/.........
Resolving dependencies...
Using sentry-ruby 5.22.4 (was 5.22.3) from source at `../sentry-ruby`
Using sentry-rails 5.22.4 (was 5.22.3) from source at `../sentry-rails`
Using sentry-sidekiq 5.22.4 (was 5.22.3) from source at `.`
Bundle complete! 19 Gemfile dependencies, 114 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.
gem build sentry-sidekiq.gemspec
Successfully built RubyGem
Name: sentry-sidekiq
Version: 5.22.4
File: sentry-sidekiq-5.22.4.gem
WARNING: description and summary are identical
WARNING: open-ended dependency on delayed_job (>= 4.0) is not recommended
if delayed_job is semantically versioned, use:
add_runtime_dependency "delayed_job", "~> 4.0"
WARNING: You have specified the uri:
https://github.com/getsentry/sentry-ruby/tree/5.22.4/sentry-delayed_job
for all of the following keys:
homepage_uri
source_code_uri
Only the first one will be shown on rubygems.org
WARNING: See https://guides.rubygems.org/specification-reference/ for help
bundle install
Bundle complete! 20 Gemfile dependencies, 102 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.
gem build sentry-delayed_job.gemspec
Successfully built RubyGem
Name: sentry-delayed_job
Version: 5.22.4
File: sentry-delayed_job-5.22.4.gem
WARN: Unresolved or ambiguous specs during Gem::Specification.reset:
stringio (>= 0)
Available/installed versions of this gem:
- 3.1.2
- 3.1.1
WARN: Clearing out unresolved specs. Try 'gem cleanup <gem>'
Please report a bug if this causes problems.
WARNING: description and summary are identical
WARNING: open-ended dependency on resque (>= 1.24) is not recommended
if resque is semantically versioned, use:
add_runtime_dependency "resque", "~> 1.24"
WARNING: You have specified the uri:
https://github.com/getsentry/sentry-ruby/tree/5.22.4/sentry-resque
for all of the following keys:
homepage_uri
source_code_uri
Only the first one will be shown on rubygems.org
WARNING: See https://guides.rubygems.org/specification-reference/ for help
bundle install
Fetching gem metadata from https://rubygems.org/.........
Resolving dependencies...
Fetching mono_logger 1.1.2
Fetching multi_json 1.15.0
Fetching ruby2_keywords 0.0.5
Using sentry-ruby 5.22.4 (was 5.21.0) from source at `../sentry-ruby`
Fetching rack-protection 4.0.0
Fetching redis-namespace 1.11.0
Fetching rubocop 1.67.0
Using sentry-rails 5.22.4 (was 5.21.0) from source at `../sentry-rails`
Installing mono_logger 1.1.2
Installing multi_json 1.15.0
Installing rack-protection 4.0.0
Installing redis-namespace 1.11.0
Installing rubocop 1.67.0
Installing ruby2_keywords 0.0.5
Fetching mustermann 3.0.3
Installing mustermann 3.0.3
Fetching sinatra 4.0.0
Installing sinatra 4.0.0
Fetching resque 2.6.0
Installing resque 2.6.0
Using sentry-resque 5.22.4 (was 5.21.0) from source at `.`
Fetching resque-scheduler 4.10.2
Installing resque-scheduler 4.10.2
Fetching resque-retry 1.8.1
Installing resque-retry 1.8.1
Bundle complete! 16 Gemfile dependencies, 115 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.
gem build sentry-resque.gemspec
Successfully built RubyGem
Name: sentry-resque
Version: 5.22.4
File: sentry-resque-5.22.4.gem
WARNING: description and summary are identical
WARNING: You have specified the uri:
https://github.com/getsentry/sentry-ruby/tree/5.22.4/sentry-opentelemetry
for all of the following keys:
homepage_uri
source_code_uri
Only the first one will be shown on rubygems.org
WARNING: See https://guides.rubygems.org/specification-reference/ for help
bundle install
Fetching gem metadata from https://rubygems.org/........
Resolving dependencies...
Using sentry-ruby 5.22.4 (was 5.22.0) from source at `../sentry-ruby`
Using sentry-opentelemetry 5.22.4 (was 5.22.0) from source at `.`
Bundle complete! 15 Gemfile dependencies, 75 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.
gem build sentry-opentelemetry.gemspec
Successfully built RubyGem
Name: sentry-opentelemetry
Version: 5.22.4
File: sentry-opentelemetry-5.22.4.gem
st0012
approved these changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependabot does not allow paths to custom gemfiles constructed dynamically, and since it's not really needed, this PR uses relative path to our common Gemfile for all the projects.
#skip-changelog