ref: Merge ReplayClipPreviewWrapper into GroupReplaysTableInner where its used #87818
+29
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
ryan953
commented
Mar 24, 2025
Comment on lines
-122
to
-123
| pageLinks={pageLinks} | ||
| visibleColumns={visibleColumns(allMobileProj)} |
There was a problem hiding this comment.
two unused props are gone now
ryan953
commented
Mar 24, 2025
Comment on lines
-23
to
-27
| const replayReaderData = useLoadReplayReader({ | ||
| orgSlug: props.orgSlug, | ||
| replaySlug: props.replaySlug, | ||
| group: props.group, | ||
| }); |
There was a problem hiding this comment.
We were already calling useLoadReplayReader from groupReplays.tsx, so this is redundant (caching helps with the fetches... but while constructing the Class we did a bunch of redundant processing and memoizing too)
ryan953
commented
Mar 24, 2025
Comment on lines
-8
to
-18
| type Props = { | ||
| group: Group; | ||
| orgSlug: string; | ||
| pageLinks: string | null; | ||
| replaySlug: string; | ||
| replays: ReplayListRecord[] | undefined; | ||
| selectedReplayIndex: number; | ||
| setSelectedReplayIndex: (index: number) => void; | ||
| visibleColumns: ReplayColumn[]; | ||
| overlayContent?: React.ReactNode; | ||
| }; |
There was a problem hiding this comment.
Not all of these props were used. So they also came out of the parent components in groupReplays.tsx
ryan953
commented
Mar 24, 2025
There was a problem hiding this comment.
This was only imported from groupReplays.tsx, so safe to delete.
scttcper
approved these changes
Mar 26, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Mar 27, 2025
… its used (#87818) Before we had: `<GroupReplaysTableInner>` with a child of `<ReplayClipPreviewWrapper>`. The Wrapper would then unconditionally render `<ReplayClipPreviewPlayer>` as it's child. These components render replay clips inside the Issues Details > Replays tab. Users can watch clips from all events within an issue. The names are each a bit confusing, and more-so because the component in the middle of the stack, `<ReplayClipPreviewWrapper>` didn't really have a strong job to do. It mostly proxied props down through the layers. This PR removes `<ReplayClipPreviewWrapper>`. Now `<GroupReplaysTableInner>` includes `<ReplayClipPreviewPlayer>` as it's direct child. The wrapper component is removed from the codebase as this was the only callsite. Also some props were required by the Wrapper, but never used by the PreviewPlayer, so I cleaned up those unused fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we had:
<GroupReplaysTableInner>with a child of<ReplayClipPreviewWrapper>. The Wrapper would then unconditionally render<ReplayClipPreviewPlayer>as it's child.These components render replay clips inside the Issues Details > Replays tab. Users can watch clips from all events within an issue.
The names are each a bit confusing, and more-so because the component in the middle of the stack,
<ReplayClipPreviewWrapper>didn't really have a strong job to do. It mostly proxied props down through the layers.This PR removes
<ReplayClipPreviewWrapper>. Now<GroupReplaysTableInner>includes<ReplayClipPreviewPlayer>as it's direct child. The wrapper component is removed from the codebase as this was the only callsite. Also some props were required by the Wrapper, but never used by the PreviewPlayer, so I cleaned up those unused fields.