ref(onboarding): Remove onboarding-load-docs-on-platform-click-and-silent-delete-on-back flag #87826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
priscilawebdev
commented
Mar 25, 2025
priscilawebdev
commented
- Contributes to https://github.com/getsentry/projects/issues/846
github-actions
bot
added
the
Scope: Frontend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #87826 +/- ##
===========================================
+ Coverage 56.22% 87.76% +31.53%
===========================================
Files 9896 9904 +8
Lines 562043 562385 +342
Branches 22146 22133 -13
===========================================
+ Hits 316025 493562 +177537
+ Misses 245588 68393 -177195
Partials 430 430 |
priscilawebdev
commented
Mar 25, 2025
| // Modal is open | ||
| await screen.findByText('Do you use a framework?'); | ||
| }); | ||
|
|
||
| it('does not render framework selection modal if vanilla js is NOT selected', async function () { |
There was a problem hiding this comment.
this test was merged with "loads doc on platform click"
…lent-delete-on-back flag
…lent-delete-on-back flag
priscilawebdev
force-pushed
the
priscila/ref/onboarding/remove-onboarding-load-docs-on-platform-click-and-silent-delete-on-back-flag
branch
from
6fad39b to
8fd10e6
Compare
priscilawebdev
changed the base branch from
master
to
priscila/ref/onboarding/backend/remove-onboarding-load-docs-on-platform-click-and-silent-delete-on-back-flag
ArthurKnaus
approved these changes
Mar 25, 2025
Base automatically changed from
priscila/ref/onboarding/backend/remove-onboarding-load-docs-on-platform-click-and-silent-delete-on-back-flag
to
master
March 25, 2025 08:23
…load-docs-on-platform-click-and-silent-delete-on-back-flag
…load-docs-on-platform-click-and-silent-delete-on-back-flag
priscilawebdev
deleted the
priscila/ref/onboarding/remove-onboarding-load-docs-on-platform-click-and-silent-delete-on-back-flag
branch
andrewshie-sentry
pushed a commit
that referenced
this pull request
Mar 27, 2025
…lent-delete-on-back flag (#87826) - Contributes to getsentry/projects#846
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.