Disable unknown exception type handling on Windows

Summary: These APIs aren't available on Windows, at least with MSVC.

Reviewed By: passy

Differential Revision: D23820257

fbshipit-source-id: bee94980fc683ecc8093f3ad6c8c1313fb003ace

first-party/fbjni/cxx/fbjni/detail/Exceptions.cpp

@@ -23,7 +23,6 @@
 #endif
 
 #include <cstdlib>
-#include <cxxabi.h>
 #include <ios>
 #include <stdexcept>
 #include <stdio.h>
@@ -32,6 +31,10 @@
 
 #include <jni.h>
 
+#ifndef _WIN32
+#include <cxxabi.h>
+#endif
+
 namespace facebook {
 namespace jni {
 
@@ -279,13 +282,17 @@ local_ref<JThrowable> convertCppExceptionToJavaException(std::exception_ptr ptr)
   } catch (const char* msg) {
     current = JUnknownCppException::create(msg);
   } catch (...) {
+#ifdef _WIN32
+    current = JUnknownCppException::create();
+#else
     const std::type_info* tinfo = abi::__cxa_current_exception_type();
     if (tinfo) {
       std::string msg = std::string("Unknown: ") + tinfo->name();
       current = JUnknownCppException::create(msg.c_str());
     } else {
       current = JUnknownCppException::create();
     }
+#endif
   }
 
   if (addCppStack) {

first-party/fbjni/test/FBJniTests.java

@@ -715,6 +715,11 @@ public void testHandleNonStdExceptionThrow() {
       nativeTestHandleNonStdExceptionThrow();
       Fail.failBecauseExceptionWasNotThrown(UnknownCppException.class);
     } catch (UnknownCppException ex) {
+      if (System.getProperty("os.name").startsWith("Windows")) {
+        // Unknown exception types not supported on Windows.
+        assertThat(ex.getMessage()).isEqualTo("Unknown");
+        return;
+      }
       // the actual string is implementation-defined and mangled, but in practice,
       // it has the name of the C++ type in it somewhere.
       assertThat(ex.getMessage()).startsWith("Unknown: ").contains("NonStdException");