Remove missing HERMESVM_USE_JS_LIBRARY_IMPLEMENTATION

Summary: This is a follow-up of D23383872 where I forgot to remove the ifndef guard of String.cpp and RegExp.cpp and related config in hermes.bzl Reviewed By: avp Differential Revision: D23593560 fbshipit-source-id: f88a845c25ff17f6a54bc80c2854cd9b36a101e1
gfx · Sep 10, 2020 · f2cd4d2 · f2cd4d2
1 parent 14685c8
commit f2cd4d2
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 9 deletions.
diff --git a/lib/VM/JSLib/RegExp.cpp b/lib/VM/JSLib/RegExp.cpp
@@ -136,7 +136,6 @@ Handle<JSObject> createRegExpConstructor(Runtime *runtime) {
   defineGetter(cons, Predefined::dollarPlus, regExpLastParenGetter);
   defineGetter(cons, Predefined::lastParen, regExpLastParenGetter);
 
-#ifndef HERMESVM_USE_JS_LIBRARY_IMPLEMENTATION
   defineMethod(
       runtime,
       proto,
@@ -182,7 +181,6 @@ Handle<JSObject> createRegExpConstructor(Runtime *runtime) {
       dpf);
 
   defineGetter(proto, Predefined::flags, regExpFlagsGetter);
-#endif // HERMESVM_USE_JS_LIBRARY_IMPLEMENTATION
 
   return cons;
 }
@@ -1103,7 +1101,6 @@ regExpPrototypeSymbolMatchAll(void *, Runtime *runtime, NativeArgs args) {
       .getHermesValue();
 }
 
-#ifndef HERMESVM_USE_JS_LIBRARY_IMPLEMENTATION
 // ES6 21.2.5.14
 // Note there is no requirement that 'this' be a RegExp object.
 CallResult<HermesValue>
@@ -1984,7 +1981,6 @@ regExpFlagsGetter(void *ctx, Runtime *runtime, NativeArgs args) {
   }
   return StringPrimitive::create(runtime, result);
 }
-#endif // HERMESVM_USE_JS_LIBRARY_IMPLEMENTATION
 
 } // namespace vm
 } // namespace hermes
diff --git a/lib/VM/JSLib/String.cpp b/lib/VM/JSLib/String.cpp
@@ -225,8 +225,6 @@ Handle<JSObject> createStringConstructor(Runtime *runtime) {
       ctx,
       stringPrototypeMatchAll,
       1);
-
-#ifndef HERMESVM_USE_JS_LIBRARY_IMPLEMENTATION
   defineMethod(
       runtime,
       stringPrototype,
@@ -318,7 +316,6 @@ Handle<JSObject> createStringConstructor(Runtime *runtime) {
       (void *)true,
       stringPrototypeIncludesOrStartsWith,
       1);
-#endif // HERMESVM_USE_JS_LIBRARY_IMPLEMENTATION
 
   return cons;
 }
@@ -1344,7 +1341,6 @@ stringPrototypeMatchAll(void *, Runtime *runtime, NativeArgs args) {
       .toCallResultHermesValue();
 }
 
-#ifndef HERMESVM_USE_JS_LIBRARY_IMPLEMENTATION
 CallResult<HermesValue>
 stringPrototypeMatch(void *, Runtime *runtime, NativeArgs args) {
   // 1. Let O be RequireObjectCoercible(this value).
@@ -2312,7 +2308,6 @@ CallResult<HermesValue>
 stringPrototypeLastIndexOf(void *, Runtime *runtime, NativeArgs args) {
   return stringDirectedIndexOf(runtime, args, true);
 }
-#endif // HERMESVM_USE_JS_LIBRARY_IMPLEMENTATION
 
 } // namespace vm
 } // namespace hermes