Prevent panic when editing forked repos by API (go-gitea#14960)

When editing forked repos using the API the BaseRepository needs to loaded in order to check its visibility otherwise there will be NPE panic. Fix go-gitea#14956 Signed-off-by: Andrew Thornton <[email protected]>
gfxlabs · Mar 11, 2021 · 5705f72 · 5705f72
1 parent c8e5c79
commit 5705f72
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/routers/api/v1/repo/repo.go b/routers/api/v1/repo/repo.go
@@ -556,6 +556,10 @@ func updateBasicProperties(ctx *context.APIContext, opts api.EditRepoOption) err
 	if opts.Private != nil {
 		// Visibility of forked repository is forced sync with base repository.
 		if repo.IsFork {
+			if err := repo.GetBaseRepo(); err != nil {
+				ctx.Error(http.StatusInternalServerError, "Unable to load base repository", err)
+				return err
+			}
 			*opts.Private = repo.BaseRepo.IsPrivate
 		}