Skip to content

Commit

Permalink
CONTRIBUTING.md: link to "Faster reviews" document (go-gitea#229)
Browse files Browse the repository at this point in the history
* CONTRIBUTING.md: link to "Faster reviews" document

* CONTRIBUTING.md: small fixes
  • Loading branch information
andreynering authored and lunny committed Nov 25, 2016
1 parent 21e8dee commit 6a28909
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,19 @@ who makes the change even if an owners or a maintainer. We use github's
pull request workflow to do that and use [lgtm](http://lgtm.co) to ensure
every PR is reviewed by at least 2 maintainers.

Please try to make your pull request easy to review for us. Please read the
["How to get faster PR reviews"](https://github.com/kubernetes/kubernetes/blob/master/docs/devel/faster_reviews.md),
guide, it got useful tips for any project you may want to contribute. See some
of the points:

- Make small pull requests. The smaller, the faster to review and the more
likely it will be merged soon.
- Don't make changes unrelated to your PR. Maybe there are typos on some
comments, maybe refactoring would welcome on a function... but if that is not
related to you PR, please make *another* PR for that.
- Split big pull requests in multiple. An incremental change will be faster to
review than a huge PR.

## Sign your work

The sign-off is a simple line at the end of the explanation for the
Expand Down

0 comments on commit 6a28909

Please sign in to comment.