Remove unneeded database loads (go-gitea#814)

Remove unnecessary calls to repo.GetOwner() in context handlers
gfxlabs · Feb 2, 2017 · 73d05a5 · 73d05a5
1 parent d7d094b
commit 73d05a5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/modules/context/repo.go b/modules/context/repo.go
@@ -185,10 +185,8 @@ func RepoAssignment(args ...bool) macaron.Handler {
 				ctx.Handle(500, "GetRepositoryByName", err)
 			}
 			return
-		} else if err = repo.GetOwner(); err != nil {
-			ctx.Handle(500, "GetOwner", err)
-			return
 		}
+		repo.Owner = owner
 
 		// Admin has super access.
 		if ctx.IsSigned && ctx.User.IsAdmin {

diff --git a/routers/api/v1/api.go b/routers/api/v1/api.go
@@ -57,10 +57,8 @@ func repoAssignment() macaron.Handler {
 				ctx.Error(500, "GetRepositoryByName", err)
 			}
 			return
-		} else if err = repo.GetOwner(); err != nil {
-			ctx.Error(500, "GetOwner", err)
-			return
 		}
+		repo.Owner = owner
 
 		if ctx.IsSigned && ctx.User.IsAdmin {
 			ctx.Repo.AccessMode = models.AccessModeOwner