Skip AllowedUserVisibilityModes validation on update user if it is an…

… organisation (go-gitea#16988) if AllowedUserVisibilityModes allow only public & limited, and orgs can be private, a user can create a repo to that organisation whitch will result in an update of the user. On this call the user is validaten and will be rejected since private is not allowed, but its not an user its an valid org ... Co-authored-by: Alexey 〒erentyev <[email protected]>
gfxlabs · Sep 8, 2021 · 8e18b41 · 8e18b41
1 parent ddc709f
commit 8e18b41
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/models/user.go b/models/user.go
@@ -1060,9 +1060,9 @@ func checkDupEmail(e Engine, u *User) error {
 	return nil
 }
 
-// validateUser check if user is valide to insert / update into database
+// validateUser check if user is valid to insert / update into database
 func validateUser(u *User) error {
-	if !setting.Service.AllowedUserVisibilityModesSlice.IsAllowedVisibility(u.Visibility) {
+	if !setting.Service.AllowedUserVisibilityModesSlice.IsAllowedVisibility(u.Visibility) && !u.IsOrganization() {
 		return fmt.Errorf("visibility Mode not allowed: %s", u.Visibility.String())
 	}