Update bash completion for `docker service {create,update} {--mode,--…

…endpoint-mode}` Signed-off-by: Harald Albers <[email protected]> (cherry picked from commit a394490) Signed-off-by: Tibor Vass <[email protected]>
gg7 · Jul 26, 2016 · 9b0ebd2 · 9b0ebd2
1 parent fc4c8d9
commit 9b0ebd2
Showing 1 changed file with 13 additions and 6 deletions.
diff --git a/contrib/completion/bash/docker b/contrib/completion/bash/docker
@@ -1710,7 +1710,6 @@ _docker_service_update() {
 		--label -l
 		--limit-cpu
 		--limit-memory
-		--mode
 		--mount -m
 		--name
 		--network
@@ -1734,6 +1733,18 @@ _docker_service_update() {
 		--registry-auth
 	"
 
+	if [ "$subcommand" = "create" ] ; then
+		options_with_args="$options_with_args
+			--mode
+		"
+
+		case "$prev" in
+			--mode)
+				COMPREPLY=( $( compgen -W "global replicated" -- "$cur" ) )
+				return
+				;;
+		esac
+	fi
 	if [ "$subcommand" = "update" ] ; then
 		options_with_args="$options_with_args
 			--arg
@@ -1751,18 +1762,14 @@ _docker_service_update() {
 
 	case "$prev" in
 		--endpoint-mode)
-			COMPREPLY=( $( compgen -W "DNSRR VIP" -- "$cur" ) )
+			COMPREPLY=( $( compgen -W "dnsrr vip" -- "$cur" ) )
 			return
 			;;
 		--env|-e)
 			COMPREPLY=( $( compgen -e -S = -- "$cur" ) )
 			__docker_nospace
 			return
 			;;
-		--mode)
-			COMPREPLY=( $( compgen -W "global replicated" -- "$cur" ) )
-			return
-			;;
 		--network)
 			__docker_complete_networks
 			return