Skip to content

Commit

Permalink
Merge pull request docker#1316 from dmcgowan/fix-janky-integration-tests
Browse files Browse the repository at this point in the history
Fix broken daemon startup with master
  • Loading branch information
stevvooe committed Jan 5, 2016
2 parents a580dae + 8d1c44f commit f277c66
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 4 deletions.
2 changes: 1 addition & 1 deletion contrib/docker-integration/run.sh
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,13 @@ docker pull $INTEGRATION_IMAGE
ID=$(docker run -d -it --privileged $volumeMount $dockerMount \
-v ${DISTRIBUTION_ROOT}:/go/src/github.com/docker/distribution \
-e "DOCKER_GRAPHDRIVER=$DOCKER_GRAPHDRIVER" \
-e "EXEC_DRIVER=$EXEC_DRIVER" \
${INTEGRATION_IMAGE} \
./run_engine.sh)

# Stop container on exit
trap "docker rm -f -v $ID" EXIT


# Wait for it to become reachable.
tries=10
until docker exec "$ID" docker version &> /dev/null; do
Expand Down
12 changes: 10 additions & 2 deletions contrib/docker-integration/run_engine.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,13 @@ echo "$IP localregistry" >> /etc/hosts

sh install_certs.sh localregistry

docker --daemon --log-level=panic \
--storage-driver="$DOCKER_GRAPHDRIVER" --exec-driver="$EXEC_DRIVER"
DOCKER_VERSION=$(docker --version | cut -d ' ' -f3 | cut -d ',' -f1)
major=$(echo "$DOCKER_VERSION"| cut -d '.' -f1)
minor=$(echo "$DOCKER_VERSION"| cut -d '.' -f2)

daemonOpts="daemon"
if [ $major -le 1 ] && [ $minor -lt 9 ]; then
daemonOpts="--daemon"
fi

docker $daemonOpts --log-level=debug --storage-driver="$DOCKER_GRAPHDRIVER"
2 changes: 1 addition & 1 deletion contrib/docker-integration/run_multiversion.sh
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ fi

# Released versions

versions="1.6.0 1.6.1 1.7.0 1.7.1"
versions="1.6.1 1.7.1 1.8.3 1.9.1"

for v in $versions; do
echo "Extracting Docker $v from dind image"
Expand Down

0 comments on commit f277c66

Please sign in to comment.