Skip to content

Commit

Permalink
Merge pull request #73 from sschuberth/master
Browse files Browse the repository at this point in the history
Upgrade Job-DSL dependency to 1.43
  • Loading branch information
ghale committed Mar 24, 2016
2 parents 6708e3a + b93ccbb commit ca1fb28
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 10 deletions.
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ dependencies {
exclude(module: 'groovy')
}

compile('org.jenkins-ci.plugins:job-dsl-core:1.42') {
compile('org.jenkins-ci.plugins:job-dsl-core:1.43') {
exclude(module: 'groovy-all')
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ class MapJobManagement extends AbstractJobManagement {
return true
}

@Override
String createOrUpdateConfigFile(ConfigFile configFile, boolean ignoreExisting){
return null
}
Expand All @@ -48,12 +49,17 @@ class MapJobManagement extends AbstractJobManagement {
}

@Override
String getCredentialsId(String credentialsDescription) {
return credentialsDescription
}
void logPluginDeprecationWarning(String pluginShortName, String minimumVersion) { }

@Override
void logPluginDeprecationWarning(String pluginShortName, String minimumVersion) { }
boolean isMinimumPluginVersionInstalled(String pluginShortName, String version) {
VersionNumber actualVersion = getPluginVersion(pluginShortName)
if (actualVersion == null) {
return false
}
VersionNumber minimumVersion = new VersionNumber(version)
return !actualVersion.isOlderThan(minimumVersion)
}

@Override
void requireMinimumPluginVersion(String pluginShortName, String version){
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,4 @@ class MapJobManagementTest extends Specification {
expect:
jm.getConfig("test") == null
}

def "getCredentials returns passed uuid" () {
expect:
jm.getCredentialsId("test") == "test"
}
}

0 comments on commit ca1fb28

Please sign in to comment.