Skip to content

Commit

Permalink
Revert "spec: Fixing Gradezilla specs that failed due to recent InstU…
Browse files Browse the repository at this point in the history
…I changes"

This can't be merged before https://gerrit.instructure.com/107305/ ...
really it should probably just be part of that commit

This reverts commit 937de48.

Change-Id: I35be80e2075c61c1d52feb2cc93e01d4b592337f
Reviewed-on: https://gerrit.instructure.com/107803
Reviewed-by: Rob Orton <[email protected]>
Tested-by: Jenkins
Product-Review: Jon Jensen <[email protected]>
QA-Review: Jon Jensen <[email protected]>
  • Loading branch information
jenseng committed Apr 6, 2017
1 parent 937de48 commit cb53fc0
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
end

it 'displays triangle warning' do
expect(ff('svg[name="IconWarningSolid"] > g').size).to be > 0
expect(ff('.Gradebook__ColumnHeaderDetail svg[aria-labelledby^="IconWarningSolid"]').size).to eq(1)
end

it 'does not include omitted assignment in final' do
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ def toggle_group_weight

it 'should display a warning icon for assignments with 0 points possible', priority: '1', test_id: 164013 do
gradezilla_page.visit(@course)
expect(ff('svg[name="IconWarningSolid"] > g').size).to be > 0
expect(ff('.Gradebook__ColumnHeaderDetail svg[aria-labelledby^="IconWarningSolid"]').size).to eq(1)
end

it 'should display a warning icon in the total column', priority: '1', test_id: 164013 do
Expand All @@ -121,8 +121,9 @@ def toggle_group_weight
header_mute_icon_selector = [
".container_1",
".slick-header-column[id*='assignment_#{@assignment2.id}']",
"svg[name=\"IconMutedSolid\"]"
"svg[aria-labelledby^=IconMutedSolid]"
].join(' ')

gradezilla_page.visit(@course)
toggle_muting(@assignment2)
expect(f("#content")).to contain_jqcss('.total-cell .icon-muted')
Expand All @@ -136,7 +137,7 @@ def toggle_group_weight
header_mute_icon_selector = [
".container_1",
".slick-header-column[id*='assignment_#{@assignment2.id}']",
"svg[name=\"IconMutedSolid\"]"
"svg[aria-labelledby^=IconMutedSolid]"
].join(' ')

gradezilla_page.visit(@course)
Expand Down

0 comments on commit cb53fc0

Please sign in to comment.