Remove unnecessary "throws Exception" from test methods

ghostdl · Apr 5, 2020 · 4600006 · 4600006
1 parent 8189a5c
commit 4600006
Show file tree

Hide file tree

Showing 20 changed files with 60 additions and 63 deletions.
diff --git a/easy-rules-core/src/test/java/org/jeasy/rules/api/FactsTest.java b/easy-rules-core/src/test/java/org/jeasy/rules/api/FactsTest.java
@@ -34,7 +34,7 @@ public class FactsTest {
     private Facts facts = new Facts();
 
     @Test
-    public void factsMustHaveUniqueName() throws Exception {
+    public void factsMustHaveUniqueName() {
         facts.put("foo", 1);
         facts.put("foo", 2);
 
@@ -92,17 +92,17 @@ public void testClear() {
     }
 
     @Test(expected = NullPointerException.class)
-    public void whenPutNullFact_thenShouldThrowNullPointerException() throws Exception {
+    public void whenPutNullFact_thenShouldThrowNullPointerException() {
         facts.put(null, "foo");
     }
 
     @Test(expected = NullPointerException.class)
-    public void whenRemoveNullFact_thenShouldThrowNullPointerException() throws Exception {
+    public void whenRemoveNullFact_thenShouldThrowNullPointerException() {
         facts.remove(null);
     }
 
     @Test(expected = NullPointerException.class)
-    public void whenGetNullFact_thenShouldThrowNullPointerException() throws Exception {
+    public void whenGetNullFact_thenShouldThrowNullPointerException() {
         facts.get(null);
     }
 }
diff --git a/easy-rules-core/src/test/java/org/jeasy/rules/api/RulesTest.java b/easy-rules-core/src/test/java/org/jeasy/rules/api/RulesTest.java
@@ -38,14 +38,14 @@ public class RulesTest {
     private Rules rules = new Rules();
 
     @Test
-    public void register() throws Exception {
+    public void register() {
         rules.register(new DummyRule());
 
         assertThat(rules).hasSize(1);
     }
 
     @Test
-    public void rulesMustHaveUniqueName() throws Exception {
+    public void rulesMustHaveUniqueName() {
         Rule r1 = new BasicRule("rule");
         Rule r2 = new BasicRule("rule");
         Set<Rule> ruleSet = new HashSet<>();
@@ -58,7 +58,7 @@ public void rulesMustHaveUniqueName() throws Exception {
     }
 
     @Test
-    public void unregister() throws Exception {
+    public void unregister() {
         DummyRule rule = new DummyRule();
         rules.register(rule);
         rules.unregister(rule);
@@ -67,7 +67,7 @@ public void unregister() throws Exception {
     }
 
     @Test
-    public void unregisterByName() throws Exception {
+    public void unregisterByName() {
         Rule r1 = new BasicRule("rule1");
         Rule r2 = new BasicRule("rule2");
         Set<Rule> ruleSet = new HashSet<>();
@@ -81,7 +81,7 @@ public void unregisterByName() throws Exception {
     }
 
     @Test
-    public void unregisterByNameNonExistingRule() throws Exception {
+    public void unregisterByNameNonExistingRule() {
         Rule r1 = new BasicRule("rule1");
         Set<Rule> ruleSet = new HashSet<>();
         ruleSet.add(r1);
@@ -93,20 +93,20 @@ public void unregisterByNameNonExistingRule() throws Exception {
     }
 
     @Test
-    public void isEmpty() throws Exception {
+    public void isEmpty() {
         assertThat(rules.isEmpty()).isTrue();
     }
 
     @Test
-    public void clear() throws Exception {
+    public void clear() {
         rules.register(new DummyRule());
         rules.clear();
 
         assertThat(rules).isEmpty();
     }
 
     @Test
-    public void sort() throws Exception {
+    public void sort() {
         Rule r1 = new BasicRule("rule", "", 1);
         Rule r2 = new BasicRule("rule", "", Integer.MAX_VALUE);
         DummyRule r3 = new DummyRule();
@@ -119,12 +119,12 @@ public void sort() throws Exception {
     }
 
     @Test(expected = NullPointerException.class)
-    public void whenRegisterNullRule_thenShouldThrowNullPointerException() throws Exception {
+    public void whenRegisterNullRule_thenShouldThrowNullPointerException() {
         rules.register(null);
     }
 
     @Test(expected = NullPointerException.class)
-    public void whenUnregisterNullRule_thenShouldThrowNullPointerException() throws Exception {
+    public void whenUnregisterNullRule_thenShouldThrowNullPointerException() {
         rules.unregister(null);
     }
 

diff --git a/easy-rules-core/src/test/java/org/jeasy/rules/core/AnnotationInheritanceTest.java b/easy-rules-core/src/test/java/org/jeasy/rules/core/AnnotationInheritanceTest.java
@@ -25,8 +25,6 @@
 
 import org.jeasy.rules.annotation.Action;
 import org.jeasy.rules.annotation.Condition;
-import org.jeasy.rules.api.Facts;
-import org.jeasy.rules.api.Rules;
 import org.jeasy.rules.api.RulesEngine;
 import org.jeasy.rules.annotation.Rule;
 import org.junit.Test;
@@ -36,7 +34,7 @@
 public class AnnotationInheritanceTest extends AbstractTest {
 
     @Test
-    public void annotationsShouldBeInherited() throws Exception {
+    public void annotationsShouldBeInherited() {
         // Given
         MyChildRule myChildRule = new MyChildRule();
         rules.register(myChildRule);

diff --git a/easy-rules-core/src/test/java/org/jeasy/rules/core/BasicRuleTest.java b/easy-rules-core/src/test/java/org/jeasy/rules/core/BasicRuleTest.java
@@ -32,7 +32,7 @@
 public class BasicRuleTest extends AbstractTest {
 
     @Test
-    public void basicRuleEvaluateShouldReturnFalse() throws Exception {
+    public void basicRuleEvaluateShouldReturnFalse() {
         BasicRule basicRule = new BasicRule();
         assertThat(basicRule.evaluate(facts)).isFalse();
     }

diff --git a/easy-rules-core/src/test/java/org/jeasy/rules/core/DefaultRulesEngineTest.java b/easy-rules-core/src/test/java/org/jeasy/rules/core/DefaultRulesEngineTest.java
@@ -112,7 +112,7 @@ public void rulesMustBeTriggeredInTheirNaturalOrder() throws Exception {
     }
 
     @Test
-    public void rulesMustBeCheckedInTheirNaturalOrder() throws Exception {
+    public void rulesMustBeCheckedInTheirNaturalOrder() {
         // Given
         when(rule1.evaluate(facts)).thenReturn(true);
         when(rule2.evaluate(facts)).thenReturn(true);
@@ -157,19 +157,19 @@ public void annotatedRulesAndNonAnnotatedRulesShouldBeUsableTogether() throws Ex
     }
 
     @Test
-    public void whenRuleNameIsNotSpecified_thenItShouldBeEqualToClassNameByDefault() throws Exception {
+    public void whenRuleNameIsNotSpecified_thenItShouldBeEqualToClassNameByDefault() {
         org.jeasy.rules.api.Rule rule = RuleProxy.asRule(new DummyRule());
         assertThat(rule.getName()).isEqualTo("DummyRule");
     }
 
     @Test
-    public void whenRuleDescriptionIsNotSpecified_thenItShouldBeEqualToConditionNameFollowedByActionsNames() throws Exception {
+    public void whenRuleDescriptionIsNotSpecified_thenItShouldBeEqualToConditionNameFollowedByActionsNames() {
         org.jeasy.rules.api.Rule rule = RuleProxy.asRule(new DummyRule());
         assertThat(rule.getDescription()).isEqualTo("when condition then action1,action2");
     }
 
     @Test
-    public void testCheckRules() throws Exception {
+    public void testCheckRules() {
         // Given
         when(rule1.evaluate(facts)).thenReturn(true);
         rules.register(rule1);
@@ -186,7 +186,7 @@ public void testCheckRules() throws Exception {
     }
 
     @Test
-    public void listenerShouldBeInvokedBeforeCheckingRules() throws Exception {
+    public void listenerShouldBeInvokedBeforeCheckingRules() {
         // Given
         when(rule1.evaluate(facts)).thenReturn(true);
         when(ruleListener.beforeEvaluate(rule1, facts)).thenReturn(true);
@@ -236,7 +236,7 @@ public void getParametersShouldReturnACopyOfTheParameters() {
     }
 
     @Test
-    public void testGetRuleListeners() throws Exception {
+    public void testGetRuleListeners() {
         // Given
         DefaultRulesEngine rulesEngine = new DefaultRulesEngine();
         rulesEngine.registerRuleListener(ruleListener);
@@ -264,7 +264,7 @@ public void getRuleListenersShouldReturnAnUnmodifiableList() {
     }
 
     @Test
-    public void testGetRulesEngineListeners() throws Exception {
+    public void testGetRulesEngineListeners() {
         // Given
         DefaultRulesEngine rulesEngine = new DefaultRulesEngine();
         rulesEngine.registerRulesEngineListener(rulesEngineListener);
@@ -309,17 +309,17 @@ public boolean when() {
         }
 
         @Action
-        public void then0() throws Exception {
+        public void then0() {
             actionSequence += "0";
         }
 
         @Action(order = 1)
-        public void then1() throws Exception {
+        public void then1() {
             actionSequence += "1";
         }
 
         @Action(order = 2)
-        public void then2() throws Exception {
+        public void then2() {
             actionSequence += "2";
             executed = true;
         }
@@ -348,12 +348,12 @@ public boolean condition() {
         }
 
         @Action(order = 1)
-        public void action1() throws Exception {
+        public void action1() {
             // no op
         }
 
         @Action(order = 2)
-        public void action2() throws Exception {
+        public void action2() {
             // no op
         }
     }

diff --git a/easy-rules-core/src/test/java/org/jeasy/rules/core/FactInjectionTest.java b/easy-rules-core/src/test/java/org/jeasy/rules/core/FactInjectionTest.java
@@ -40,7 +40,7 @@
 public class FactInjectionTest {
 
     @Test
-    public void declaredFactsShouldBeCorrectlyInjectedByNameOrType() throws Exception {
+    public void declaredFactsShouldBeCorrectlyInjectedByNameOrType() {
         // Given
         Object fact1 = new Object();
         Object fact2 = new Object();
@@ -62,7 +62,7 @@ public void declaredFactsShouldBeCorrectlyInjectedByNameOrType() throws Exceptio
     }
 
     @Test
-    public void rulesShouldBeExecutedWhenFactsAreCorrectlyInjected() throws Exception {
+    public void rulesShouldBeExecutedWhenFactsAreCorrectlyInjected() {
         // Given
         Facts facts = new Facts();
         facts.put("rain", true);
@@ -82,7 +82,7 @@ public void rulesShouldBeExecutedWhenFactsAreCorrectlyInjected() throws Exceptio
     }
 
     @Test(expected = RuntimeException.class)
-    public void whenFactTypeDoesNotMatchParameterType_thenShouldThrowRuntimeException() throws Exception {
+    public void whenFactTypeDoesNotMatchParameterType_thenShouldThrowRuntimeException() {
         // Given
         Facts facts = new Facts();
         facts.put("age", "foo");
@@ -97,7 +97,7 @@ public void whenFactTypeDoesNotMatchParameterType_thenShouldThrowRuntimeExceptio
     }
 
     @Test
-    public void whenADeclaredFactIsMissingInEvaluateMethod_thenTheRuleShouldNotBeExecuted() throws Exception {
+    public void whenADeclaredFactIsMissingInEvaluateMethod_thenTheRuleShouldNotBeExecuted() {
         // Given
         Facts facts = new Facts();
         AgeRule ageRule = new AgeRule();
@@ -112,7 +112,7 @@ public void whenADeclaredFactIsMissingInEvaluateMethod_thenTheRuleShouldNotBeExe
     }
 
     @Test
-    public void whenADeclaredFactIsMissingInExecuteMethod_thenTheRuleShouldNotBeExecuted() throws Exception {
+    public void whenADeclaredFactIsMissingInExecuteMethod_thenTheRuleShouldNotBeExecuted() {
         // Given
         Facts facts = new Facts();
         AnotherDummyRule rule = new AnotherDummyRule();

diff --git a/easy-rules-core/src/test/java/org/jeasy/rules/core/InferenceRulesEngineTest.java b/easy-rules-core/src/test/java/org/jeasy/rules/core/InferenceRulesEngineTest.java
@@ -35,7 +35,7 @@
 public class InferenceRulesEngineTest {
 
     @Test
-    public void testCandidateSelection() throws Exception {
+    public void testCandidateSelection() {
         // Given
         Facts facts = new Facts();
         facts.put("foo", true);
@@ -53,7 +53,7 @@ public void testCandidateSelection() throws Exception {
     }
 
     @Test
-    public void testCandidateOrdering() throws Exception {
+    public void testCandidateOrdering() {
         // Given
         Facts facts = new Facts();
         facts.put("foo", true);

diff --git a/easy-rules-core/src/test/java/org/jeasy/rules/core/RuleBuilderTest.java b/easy-rules-core/src/test/java/org/jeasy/rules/core/RuleBuilderTest.java
@@ -31,7 +31,6 @@
 import org.mockito.Mock;
 import org.mockito.junit.MockitoJUnitRunner;
 
-import static java.util.Arrays.asList;
 import static org.assertj.core.api.Assertions.assertThat;
 
 @RunWith(MockitoJUnitRunner.class)
@@ -43,7 +42,7 @@ public class RuleBuilderTest {
     private Action action1, action2;
 
     @Test
-    public void testDefaultRuleCreationWithDefaultValues() throws Exception {
+    public void testDefaultRuleCreationWithDefaultValues() {
         // when
         Rule rule = new RuleBuilder().build();
 
@@ -55,7 +54,7 @@ public void testDefaultRuleCreationWithDefaultValues() throws Exception {
     }
 
     @Test
-    public void testDefaultRuleCreationWithCustomValues() throws Exception {
+    public void testDefaultRuleCreationWithCustomValues() {
         // when
         Rule rule = new RuleBuilder()
                 .name("myRule")

diff --git a/easy-rules-core/src/test/java/org/jeasy/rules/core/RuleDefinitionValidatorTest.java b/easy-rules-core/src/test/java/org/jeasy/rules/core/RuleDefinitionValidatorTest.java
@@ -47,7 +47,7 @@ public void notAnnotatedRuleMustNotBeAccepted() {
     }
 
     @Test
-    public void withCustomAnnotationThatIsItselfAnnotatedWithTheRuleAnnotation() throws Throwable {
+    public void withCustomAnnotationThatIsItselfAnnotatedWithTheRuleAnnotation() {
         ruleDefinitionValidator.validateRuleDefinition(new AnnotatedRuleWithMetaRuleAnnotation());
     }
 

diff --git a/easy-rules-core/src/test/java/org/jeasy/rules/core/RuleListenerTest.java b/easy-rules-core/src/test/java/org/jeasy/rules/core/RuleListenerTest.java
@@ -46,7 +46,7 @@ public void setup() throws Exception {
     }
 
     @Test
-    public void whenTheRuleExecutesSuccessfully_thenOnSuccessShouldBeExecuted() throws Exception {
+    public void whenTheRuleExecutesSuccessfully_thenOnSuccessShouldBeExecuted() {
         // Given
         when(rule1.evaluate(facts)).thenReturn(true);
         rules.register(rule1);
@@ -82,7 +82,7 @@ public void whenTheRuleFails_thenOnFailureShouldBeExecuted() throws Exception {
     }
 
     @Test
-    public void whenListenerBeforeEvaluateReturnsFalse_thenTheRuleShouldBeSkippedBeforeBeingEvaluated() throws Exception {
+    public void whenListenerBeforeEvaluateReturnsFalse_thenTheRuleShouldBeSkippedBeforeBeingEvaluated() {
         // Given
         when(ruleListener1.beforeEvaluate(rule1, facts)).thenReturn(false);
         rules.register(rule1);
@@ -95,7 +95,7 @@ public void whenListenerBeforeEvaluateReturnsFalse_thenTheRuleShouldBeSkippedBef
     }
 
     @Test
-    public void whenListenerBeforeEvaluateReturnsTrue_thenTheRuleShouldBeEvaluated() throws Exception {
+    public void whenListenerBeforeEvaluateReturnsTrue_thenTheRuleShouldBeEvaluated() {
         // Given
         when(ruleListener1.beforeEvaluate(rule1, facts)).thenReturn(true);
         rules.register(rule1);
@@ -108,7 +108,7 @@ public void whenListenerBeforeEvaluateReturnsTrue_thenTheRuleShouldBeEvaluated()
     }
 
     @Test
-    public void whenTheRuleEvaluatesToTrue_thenTheListenerShouldBeInvoked() throws Exception {
+    public void whenTheRuleEvaluatesToTrue_thenTheListenerShouldBeInvoked() {
         // Given
         when(rule1.evaluate(facts)).thenReturn(true);
         rules.register(rule1);
@@ -121,7 +121,7 @@ public void whenTheRuleEvaluatesToTrue_thenTheListenerShouldBeInvoked() throws E
     }
 
     @Test
-    public void whenTheRuleEvaluatesToFalse_thenTheListenerShouldBeInvoked() throws Exception {
+    public void whenTheRuleEvaluatesToFalse_thenTheListenerShouldBeInvoked() {
         // Given
         when(rule1.evaluate(facts)).thenReturn(false);
         rules.register(rule1);

diff --git a/easy-rules-core/src/test/java/org/jeasy/rules/core/RulesEngineListenerTest.java b/easy-rules-core/src/test/java/org/jeasy/rules/core/RulesEngineListenerTest.java
@@ -63,7 +63,7 @@ public void rulesEngineListenersShouldBeCalledInOrderWhenFiringRules() throws Ex
     }
 
     @Test
-    public void rulesEngineListenersShouldBeCalledInOrderWhenCheckingRules() throws Exception {
+    public void rulesEngineListenersShouldBeCalledInOrderWhenCheckingRules() {
         // Given
         when(rule1.evaluate(facts)).thenReturn(true);
         rules.register(rule1);
-Original file line number
+Diff line change
@@ Expand Up / @@ -47,7 +47,7 @@ public void notAnnotatedRuleMustNotBeAccepted() { @@
         }
         @Test
-        public void withCustomAnnotationThatIsItselfAnnotatedWithTheRuleAnnotation() throws Throwable {
+        public void withCustomAnnotationThatIsItselfAnnotatedWithTheRuleAnnotation() {
             ruleDefinitionValidator.validateRuleDefinition(new AnnotatedRuleWithMetaRuleAnnotation());
         }
@@ Expand Down @@