core: add build option to disable sentry #3934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcollie
force-pushed
the
disable-sentry
branch
4 times, most recently
from
0b16d86 to
f2c8b29
Compare
mitchellh
requested changes
Dec 29, 2024
jcollie
force-pushed
the
disable-sentry
branch
from
f2c8b29 to
ef551ca
Compare
mitchellh
force-pushed
the
disable-sentry
branch
from
ef551ca to
7a5ef3d
Compare
|
Updated to remove the macOS CI test. macOS builds are already slow and expensive as it is, I don't think this is a common enough config on macOS to warrant it. Kept Linux. Also removed the Windows check since we default to false on Windows anyways. |
mitchellh
approved these changes
Jan 2, 2025
mitchellh
added a commit
that referenced
this pull request
Jan 2, 2025
This disables compiling/linking Sentry automatically on platforms other than macOS, which removes a potential blocker for getting Ghostty running on *BSD or other systems. This is also useful for the security paranoid that don't want any chance that sensitive information could be captured in a crash dump.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disables compiling/linking Sentry automatically on platforms other than macOS, which removes a potential blocker for getting Ghostty running on *BSD or other systems.
This is also useful for the security paranoid that don't want any chance that sensitive information could be captured in a crash dump.