Skip to content

Commit

Permalink
Remove Gemfile.lock and update Ruby
Browse files Browse the repository at this point in the history
The Gemfile.lock is not a file that we want checked in with the gem. The
purpose of a Gemfile.lock is to lock in a combination of dependencies
for an application. In the case of a gem, we are just specifying the
limits for our dependency versions in the gemspec and are not locking in
a combination of dependencies (since ultimately, the application is
in charge of it's own dependencies).

The only effect the Gemfile.lock has in this project is for when running
it in the dummy app; is has no effect on any of the applications it's
installed in. The gem should work against the latest specified in it's
gemspec so there is no reason to pin the dummy app to the version in a
Gemfile.lock checked into source control.

More info in this blog post: https://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/
  • Loading branch information
rreinhardt9 authored and wernull committed Jul 2, 2020
1 parent 0b5c207 commit a67fa0e
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 165 deletions.
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,5 @@ spec/dummy/db/*.sqlite3-journal
spec/dummy/log/*.log
spec/dummy/tmp/
.rubocop-https*

Gemfile.lock
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@ gemspec
# Git. Remember to move these dependencies to your gemspec before releasing
# your gem to rubygems.org.

ruby '~> 2.4'
ruby '~> 2.6.2'

gem 'pry', group: [:development, :test]
164 changes: 0 additions & 164 deletions Gemfile.lock

This file was deleted.

0 comments on commit a67fa0e

Please sign in to comment.