Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use matrix for build-and-test CI workflow #644

Closed
wants to merge 1 commit into from

Conversation

64J0
Copy link
Member

@64J0 64J0 commented Jan 20, 2025

Description

Use a matrix strategy for build-and-test CI workflow.

How to test

Check CI.

Related issues

Continuation of #639.

@TheAngryByrd
Copy link
Member

I'm actually not sure why a matrix would be needed. The test project already tests against different runtimes.

@64J0
Copy link
Member Author

64J0 commented Jan 20, 2025

I'm actually not sure why a matrix would be needed. The test project already tests against different runtimes.

From my understanding, the idea is to test each version alone in a single environment. It's related to this discussion: #639 (comment).

Anyway, this is currently not feasible due to the samples, as shown by this PR, since they demand multiple .NET versions to build.

@TheAngryByrd
Copy link
Member

Yeah, I don't understand @nojaf's original comment. Unless you have to do it because of weird tooling testing, doesn't make sense to me to put it in a matrix. I guess you could run a TFM specifically in a runner but seems like overkill if the tests are fast enough.

@64J0 64J0 added the github_actions Pull requests that update GitHub Actions code label Jan 20, 2025
@64J0
Copy link
Member Author

64J0 commented Jan 20, 2025

I'll close this PR for now, later we can revisit this decision.

@64J0 64J0 closed this Jan 20, 2025
@64J0 64J0 deleted the use-matrix-for-build-and-test-ci branch January 20, 2025 21:54
@nojaf
Copy link
Contributor

nojaf commented Jan 21, 2025

My remark was more about running the sample with that specific SDK installed.
Right now, you install all of them but that might not be case on the user's machine.

@64J0
Copy link
Member Author

64J0 commented Jan 21, 2025

It must be feasible when targeting Giraffe's src/ folder. What do you think about adding a new workflow that runs with a matrix strategy just to check this folder's codebase using specific OS + SDK combinations?

@nojaf
Copy link
Contributor

nojaf commented Jan 21, 2025

Well, it is probably doable but I don't really have any opinion on this.
Might be overkill and you could just install latest 9 SDK.
I'm not sure what it really changes in the grand scheme of things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants