Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Protocols for custom dependencies & targets #19

Merged
merged 1 commit into from
Apr 8, 2023
Merged

Conversation

truhanen
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Mar 26, 2023

Codecov Report

Patch coverage: 95.74% and project coverage change: +0.65 🎉

Comparison is base (d78fba0) 94.48% compared to head (421150e) 95.14%.

❗ Current head 421150e differs from pull request most recent head bed49b6. Consider uploading reports for the commit bed49b6 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #19      +/-   ##
===========================================
+ Coverage    94.48%   95.14%   +0.65%     
===========================================
  Files            8        8              
  Lines          381      391      +10     
===========================================
+ Hits           360      372      +12     
+ Misses          21       19       -2     
Impacted Files Coverage Δ
gird/run.py 77.55% <33.33%> (ø)
gird/object.py 94.28% <94.28%> (ø)
gird/__init__.py 100.00% <100.00%> (ø)
gird/common.py 100.00% <100.00%> (+6.25%) ⬆️
gird/gird.py 98.75% <100.00%> (+<0.01%) ⬆️
gird/rule.py 100.00% <100.00%> (ø)
gird/rulesorter.py 100.00% <100.00%> (+3.70%) ⬆️
girdfile.py 91.83% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@truhanen truhanen force-pushed the feat/object branch 15 times, most recently from 144307b to 5228ca6 Compare March 27, 2023 11:32
@truhanen truhanen changed the title FEAT: Object class for arbitrary dependencies & targets FEAT: Object class for custom dependencies & targets Mar 27, 2023
@truhanen truhanen changed the title FEAT: Object class for custom dependencies & targets FEAT: Object Protocol for custom dependencies & targets Mar 27, 2023
@truhanen truhanen force-pushed the feat/object branch 3 times, most recently from 516150b to 727a5f6 Compare March 29, 2023 17:35
@truhanen truhanen changed the title FEAT: Object Protocol for custom dependencies & targets FEAT: Object protocol for custom dependencies & targets Mar 29, 2023
@truhanen truhanen force-pushed the feat/object branch 5 times, most recently from 53c0b54 to 258548c Compare April 1, 2023 09:26
@truhanen truhanen force-pushed the feat/object branch 6 times, most recently from 609c22f to 0def0d8 Compare April 2, 2023 14:22
@truhanen truhanen changed the title FEAT: Object protocol for custom dependencies & targets FEAT: Protocols for custom dependencies & targets Apr 8, 2023
- A user can now implement custom dependencies and targets by implementing the
  new TimeTracked protocol.
- Targets and dependencies, except function dependencies, are now internally
  handled as objects that implement the new Object & TimeTracked protocols.
- Phony now implements the Object protocol.
- Paths are internally handled as instances of the new TimeTrackedPath class.
- Removed the format_target function. The Object.id property now handles
  possible formatting.
- Related refactoring.
@truhanen truhanen force-pushed the feat/object branch 2 times, most recently from 070ea7c to bed49b6 Compare April 8, 2023 12:33
@truhanen truhanen merged commit bed49b6 into develop Apr 8, 2023
@truhanen truhanen deleted the feat/object branch April 8, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant