Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: Use Ninja instead of Make [WIP] #3

Closed
wants to merge 1 commit into from
Closed

FEAT: Use Ninja instead of Make [WIP] #3

wants to merge 1 commit into from

Conversation

truhanen
Copy link
Collaborator

@truhanen truhanen commented Feb 24, 2023 •
edited
Loading

Tested how Make could be replaced by Ninja.

Notes about the Ninja implementation, and reasons for not switching to Ninja.

  • Ninja doesn't have similar support for phony targets. If a file with the name of a target exists, the target's rule won't be run.
  • Ninja buffers all command output, preventing, e.g., Gird recipes that require user input.
  • Ninja has a different rule definition scheme, which complicates the interface with Gird.

@truhanen truhanen force-pushed the feat/ninja branch 9 times, most recently from a444bef to b100302 Compare February 25, 2023 16:33
@truhanen
FEAT: Use Ninja instead of Make [WIP]
ca90359 
- Check the added TODO points for something that should still be figured out.
- Increased the version number to 1.3.0.
@truhanen truhanen closed this Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@truhanen