enable uncle tests and fix uncle enpoint parameters (0xPolygonHermez#…

…1861)
giskook · Mar 20, 2023 · dfb28a1 · dfb28a1
1 parent 74963d9
commit dfb28a1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 12 deletions.
diff --git a/jsonrpc/endpoints_eth.go b/jsonrpc/endpoints_eth.go
@@ -787,25 +787,25 @@ func (e *EthEndpoints) Syncing() (interface{}, types.Error) {
 
 // GetUncleByBlockHashAndIndex returns information about a uncle of a
 // block by hash and uncle index position
-func (e *EthEndpoints) GetUncleByBlockHashAndIndex() (interface{}, types.Error) {
+func (e *EthEndpoints) GetUncleByBlockHashAndIndex(hash types.ArgHash, index types.Index) (interface{}, types.Error) {
 	return nil, nil
 }
 
 // GetUncleByBlockNumberAndIndex returns information about a uncle of a
 // block by number and uncle index position
-func (e *EthEndpoints) GetUncleByBlockNumberAndIndex() (interface{}, types.Error) {
+func (e *EthEndpoints) GetUncleByBlockNumberAndIndex(number types.BlockNumber, index types.Index) (interface{}, types.Error) {
 	return nil, nil
 }
 
 // GetUncleCountByBlockHash returns the number of uncles in a block
 // matching the given block hash
-func (e *EthEndpoints) GetUncleCountByBlockHash() (interface{}, types.Error) {
+func (e *EthEndpoints) GetUncleCountByBlockHash(hash types.ArgAddress) (interface{}, types.Error) {
 	return "0x0", nil
 }
 
 // GetUncleCountByBlockNumber returns the number of uncles in a block
 // matching the given block number
-func (e *EthEndpoints) GetUncleCountByBlockNumber() (interface{}, types.Error) {
+func (e *EthEndpoints) GetUncleCountByBlockNumber(number types.BlockNumber) (interface{}, types.Error) {
 	return "0x0", nil
 }
 

diff --git a/jsonrpc/endpoints_eth_test.go b/jsonrpc/endpoints_eth_test.go
@@ -959,8 +959,6 @@ func TestGetL2BlockByNumber(t *testing.T) {
 }
 
 func TestGetUncleByBlockHashAndIndex(t *testing.T) {
-	// TODO: skipping not implemented func
-	t.Skip()
 	s, _, _ := newSequencerMockedServer(t)
 	defer s.Stop()
 
@@ -979,8 +977,6 @@ func TestGetUncleByBlockHashAndIndex(t *testing.T) {
 }
 
 func TestGetUncleByBlockNumberAndIndex(t *testing.T) {
-	// TODO: skipping not implemented func
-	t.Skip()
 	s, _, _ := newSequencerMockedServer(t)
 	defer s.Stop()
 
@@ -999,8 +995,6 @@ func TestGetUncleByBlockNumberAndIndex(t *testing.T) {
 }
 
 func TestGetUncleCountByBlockHash(t *testing.T) {
-	// TODO: skipping not implemented func
-	t.Skip()
 	s, _, _ := newSequencerMockedServer(t)
 	defer s.Stop()
 
@@ -1019,8 +1013,6 @@ func TestGetUncleCountByBlockHash(t *testing.T) {
 }
 
 func TestGetUncleCountByBlockNumber(t *testing.T) {
-	// TODO: skipping not implemented func
-	t.Skip()
 	s, _, _ := newSequencerMockedServer(t)
 	defer s.Stop()