Code review changes.

gislan · Sep 28, 2017 · 61b26f9 · 61b26f9
1 parent 1a8bb82
commit 61b26f9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/include/grpc/grpc_security.h b/include/grpc/grpc_security.h
@@ -249,7 +249,7 @@ typedef struct {
   void *reserved;
 } grpc_auth_metadata_context;
 
-/** Maximum number of credentials returnable by a credentials plugin via
+/** Maximum number of metadata entries returnable by a credentials plugin via
     a synchronous return. */
 #define GRPC_METADATA_CREDENTIALS_PLUGIN_SYNC_MAX 4
 

diff --git a/src/cpp/client/secure_credentials.cc b/src/cpp/client/secure_credentials.cc
@@ -178,12 +178,12 @@ int MetadataCredentialsPluginWrapper::GetMetadata(
     w->thread_pool_->Add(
         std::bind(&MetadataCredentialsPluginWrapper::InvokePlugin, w, context,
                   cb, user_data, nullptr, nullptr, nullptr, nullptr));
-    return false;
+    return 0;
   } else {
     // Synchronous return.
     w->InvokePlugin(context, cb, user_data, creds_md, num_creds_md, status,
                     error_details);
-    return true;
+    return 1;
   }
 }