Set the test timeout to 15 seconds #1363
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test default timeout is 5 seconds. The `beforeAll` step has a separate timeout. This test was timing out originally at 9 seconds, so that indicates the `beforeAll` step takes around 4 seconds. Experimenting showed the test completes around 12-15 seconds, of which 4 seconds are the `beforeAll` step, so the test itself takes 8-11 seconds. So a 15 second timeout should be all we need.
There was a problem hiding this comment.
Copilot encountered an error and was unable to review this pull request. You can try again, by re-requesting a review.
This was referenced Dec 11, 2024
JamieMagee
approved these changes
Dec 11, 2024
kbukum1
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test default timeout is 5 seconds. The
beforeAllstep has a separate timeout.This test was timing out originally at 9 seconds, so that indicates the
beforeAllstep takes around 4 seconds.Experimenting showed the test completes around 12-15 seconds, of which 4 seconds are the
beforeAllstep, so the test itself takes 8-11 seconds. But I forgot we have auto-merge enabled, so my experimental timeout of 30 seconds got merged when I wasn't planning to...A 15 second timeout should be all we need.