Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add apt_generated_test/ #3193

Merged
merged 1 commit into from
Oct 3, 2019
Merged

Add apt_generated_test/ #3193

merged 1 commit into from
Oct 3, 2019

Conversation

koppor
Copy link
Contributor

@koppor koppor commented Oct 1, 2019

Reasons for making this change:

The annotation processing creates a separate sub-directory for test cases.

Links to documentation supporting these rule changes:

Did not find it. A developer tested it in Eclipse and manually added that directory.

@koppor koppor mentioned this pull request Oct 1, 2019
6 tasks
@shiftkey
Copy link
Member

shiftkey commented Oct 3, 2019

Found some links on the Eclipse bugtracker:

Since upgrading to Eclipse Photon, my Maven submodules get unwanted .gitignore files in their roots with an ignore added for .apt_generated_tests/

I've excluded this already in my global git configuration (.gitignore_global) and don't want my to find .gitignore files in my Maven submodules as all ignores are either handled globally or in the root of my Maven project, not at submodule level.

The folder for files generated for test sources can be configured in the project settings "Java Compiler" > "Annotation Processing" with the new setting "Generated test source directory:" (default value ".apt_generated_tests"). If no test code is present in the project, no corresponding folder is created or added to the classpath.

This seems like a reasonable inclusion.

Copy link
Member

@shiftkey shiftkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@koppor thanks!

@shiftkey shiftkey merged commit e95b1be into github:master Oct 3, 2019
@koppor koppor deleted the patch-2 branch October 7, 2019 04:56
tokuhira pushed a commit to tokuhira/gitignore that referenced this pull request Dec 16, 2019
r2pgl pushed a commit to r2pgl/gitignore that referenced this pull request Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants