MDL-38129 gradeexport: custom profile fields case problem

Do not use custom pfofile field name as a field alias in DB query, use field id instead. DML lowercases all column aliases and fields with uppercase letters no longer match.
gjb2048 · Jul 18, 2017 · 1ef14a5 · 1ef14a5
1 parent 16a68a2
commit 1ef14a5
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/grade/lib.php b/grade/lib.php
@@ -191,7 +191,7 @@ public function init() {
                             LEFT JOIN (SELECT * FROM {user_info_data}
                                 WHERE fieldid = :cf$customfieldscount) cf$customfieldscount
                             ON u.id = cf$customfieldscount.userid";
-                    $userfields .= ", cf$customfieldscount.data AS customfield_{$field->shortname}";
+                    $userfields .= ", cf$customfieldscount.data AS customfield_{$field->customid}";
                     $params['cf'.$customfieldscount] = $field->customid;
                     $customfieldscount++;
                 }
@@ -3191,7 +3191,7 @@ public static function get_plugins_export($courseid) {
      */
     public static function get_user_field_value($user, $field) {
         if (!empty($field->customid)) {
-            $fieldname = 'customfield_' . $field->shortname;
+            $fieldname = 'customfield_' . $field->customid;
             if (!empty($user->{$fieldname}) || is_numeric($user->{$fieldname})) {
                 $fieldvalue = $user->{$fieldname};
             } else {