MDL-75085 external: Fix external_multiple_structure parameter passing

Some calls to the external_multiple_structure's constructor incorrectly pass parameters where the value for the $description parameter is not being passed. This results to invalid values being passed for the $required parameter.
gjb2048 · Feb 2, 2023 · a85c424 · a85c424
1 parent 2147bd6
commit a85c424
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/completion/classes/external.php b/completion/classes/external.php
@@ -345,6 +345,7 @@ public static function get_activities_completion_status_returns() {
                                         )
                                     ]
                                 ),
+                                'Completion status details',
                                 VALUE_DEFAULT,
                                 []
                             ),

diff --git a/course/externallib.php b/course/externallib.php
@@ -488,6 +488,7 @@ public static function get_course_contents_returns() {
                                                 'dataid' => new external_value(PARAM_NOTAGS, 'cm data id', VALUE_OPTIONAL),
                                             )
                                         ),
+                                        'Course dates',
                                         VALUE_DEFAULT,
                                         []
                                     ),
@@ -519,7 +520,7 @@ public static function get_course_contents_returns() {
                                                             VALUE_OPTIONAL
                                                    ),
                                               )
-                                          ), VALUE_DEFAULT, array()
+                                          ), 'Course contents', VALUE_DEFAULT, array()
                                       ),
                                     'contentsinfo' => new external_single_structure(
                                         array(
@@ -1310,7 +1311,7 @@ public static function duplicate_course_parameters() {
                                 'value' => new external_value(PARAM_RAW, 'the value for the option 1 (yes) or 0 (no)'
                             )
                         )
-                    ), VALUE_DEFAULT, array()
+                    ), 'Course duplication options', VALUE_DEFAULT, array()
                 ),
             )
         );
@@ -1537,7 +1538,7 @@ public static function import_course_parameters() {
                                 'value' => new external_value(PARAM_RAW, 'the value for the option 1 (yes) or 0 (no)'
                             )
                         )
-                    ), VALUE_DEFAULT, array()
+                    ), 'Course import options', VALUE_DEFAULT, array()
                 ),
             )
         );
-Original file line number
+Diff line change
@@ Expand Up @@
                                             )
                                         ]
                                     ),
+                                    'Completion status details',
                                     VALUE_DEFAULT,
                                     []
                                 ),
@@ Expand Down @@