Skip to content

Commit

Permalink
Merge branch 'MDL-64821-master-2' of https://github.com/ryanwyllie/mo…
Browse files Browse the repository at this point in the history
  • Loading branch information
snake committed Sep 26, 2019
2 parents 07fd11f + 15ecfac commit c3122df
Show file tree
Hide file tree
Showing 50 changed files with 2,204 additions and 183 deletions.
2 changes: 1 addition & 1 deletion files/classes/external/stored_file_exporter.php
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ protected function get_other_values(renderer_base $output) {
$filenameshort .= substr($filename, -4);
}

$icon = $this->file->is_directory() ? file_folder_icon() : file_file_icon($this->file);
$icon = $this->file->is_directory() ? file_folder_icon(128) : file_file_icon($this->file, 128);

$url = moodle_url::make_pluginfile_url(
$this->file->get_contextid(),
Expand Down
8 changes: 4 additions & 4 deletions lib/outputrenderers.php
Original file line number Diff line number Diff line change
Expand Up @@ -2241,6 +2241,7 @@ function render_rating(rating $rating) {
if ($rating->user_can_view_aggregate()) {

$aggregatelabel = $ratingmanager->get_aggregate_label($rating->settings->aggregationmethod);
$aggregatelabel = html_writer::tag('span', $aggregatelabel, array('class'=>'rating-aggregate-label'));
$aggregatestr = $rating->get_aggregate_string();

$aggregatehtml = html_writer::tag('span', $aggregatestr, array('id' => 'ratingaggregate'.$rating->itemid, 'class' => 'ratingaggregate')).' ';
Expand All @@ -2251,17 +2252,16 @@ function render_rating(rating $rating) {
}
$aggregatehtml .= html_writer::tag('span', $countstr, array('id'=>"ratingcount{$rating->itemid}", 'class' => 'ratingcount')).' ';

$ratinghtml .= html_writer::tag('span', $aggregatelabel, array('class'=>'rating-aggregate-label'));
if ($rating->settings->permissions->viewall && $rating->settings->pluginpermissions->viewall) {

$nonpopuplink = $rating->get_view_ratings_url();
$popuplink = $rating->get_view_ratings_url(true);

$action = new popup_action('click', $popuplink, 'ratings', array('height' => 400, 'width' => 600));
$ratinghtml .= $this->action_link($nonpopuplink, $aggregatehtml, $action);
} else {
$ratinghtml .= $aggregatehtml;
$aggregatehtml = $this->action_link($nonpopuplink, $aggregatehtml, $action);
}

$ratinghtml .= html_writer::tag('span', $aggregatelabel . $aggregatehtml, array('class' => 'rating-aggregate-container'));
}

$formstart = null;
Expand Down
2 changes: 1 addition & 1 deletion mod/forum/amd/build/discussion.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion mod/forum/amd/build/discussion.min.js.map

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions mod/forum/amd/build/discussion_modern.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions mod/forum/amd/build/discussion_modern.min.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion mod/forum/amd/build/inpage_reply.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit c3122df

Please sign in to comment.