auth: allow 0 coin accounts in genesis (cosmos#8714)

* allow zero accounts * fix test * fix test
gkblack · Feb 26, 2021 · a786830 · a786830
1 parent 2139212
commit a786830
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 8 deletions.
diff --git a/x/bank/types/balance.go b/x/bank/types/balance.go
@@ -34,11 +34,6 @@ func (b Balance) Validate() error {
 	if err != nil {
 		return err
 	}
-
-	if len(b.Coins) == 0 {
-		return fmt.Errorf("empty or nil coins for address %s", b.Address)
-	}
-
 	seenDenoms := make(map[string]bool)
 
 	// NOTE: we perform a custom validation since the coins.Validate function

diff --git a/x/bank/types/balance_test.go b/x/bank/types/balance_test.go
@@ -29,7 +29,7 @@ func TestBalanceValidate(t *testing.T) {
 			bank.Balance{
 				Address: "cosmos1yq8lgssgxlx9smjhes6ryjasmqmd3ts2559g0t",
 			},
-			true,
+			false,
 		},
 		{
 			"dup coins",

diff --git a/x/bank/types/genesis_test.go b/x/bank/types/genesis_test.go
@@ -72,15 +72,15 @@ func TestGenesisStateValidate(t *testing.T) {
 			true,
 		},
 		{
-			"invalid balance",
+			"0  balance",
 			GenesisState{
 				Balances: []Balance{
 					{
 						Address: "cosmos1yq8lgssgxlx9smjhes6ryjasmqmd3ts2559g0t",
 					},
 				},
 			},
-			true,
+			false,
 		},
 		{
 			"dup Metadata",
-Original file line number
+Diff line change
@@ Expand Up / @@ -29,7 +29,7 @@ func TestBalanceValidate(t *testing.T) { @@
     			bank.Balance{
     				Address: "cosmos1yq8lgssgxlx9smjhes6ryjasmqmd3ts2559g0t",
     			},
-    			true,
+    			false,
     		},
     		{
     			"dup coins",
@@ Expand Down @@