SIO-1254 Do not spam admins when evaluation of a deleted submission f…

…ails Change-Id: Ic0a8a29f6d78891ad3db2eb8c6ae563a7629a369
gkju · Aug 22, 2013 · 40a688d · 40a688d
1 parent 6f9df2e
commit 40a688d
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/oioioi/contests/handlers.py b/oioioi/contests/handlers.py
@@ -95,6 +95,14 @@ def mail_admins_on_error(env, exc_info, **kwargs):
            * `env['submission_id']`
     """
 
+    # We don't want to spam admins when the evaluation of a deleted
+    # submission fails. See also SIO-1254.
+    try:
+        if 'submission_id' in env:
+            Submission.objects.get(id=env['submission_id'])
+    except Submission.DoesNotExist:
+        return env
+
     try:
         mail_admins("System Error evaluating submission #%s" %
                     env.get('submission_id', '???'),