New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move macro from Http to PendingRequest #2

Merged

wecc merged 1 commit into master from macro-pendingrequest

Nov 10, 2020

Contributor

ttrig commented Nov 9, 2020 •

edited

Loading

This makes it possible to chain "withCorrelationId" on a PendingRequest.

// before
Http::withToken('secret')->withCorrelationId()->post('/api'); // BadMethodCallException 
Http::withCorrelationId()->withToken('secret')->post('/api'); // works

// after
Http::withToken('secret')->withCorrelationId()->post('/api'); // works
Http::withCorrelationId()->withToken('secret')->post('/api'); // works


          Move macro from Http to PendingRequest

be8556f

ttrig requested review from wecc and emil-nasso

November 9, 2020 13:31

wecc approved these changes

View reviewed changes

emil-nasso approved these changes

View reviewed changes

wecc merged commit 358abb8 into master

wecc deleted the macro-pendingrequest branch

November 10, 2020 08:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet