Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor #9

Merged
merged 1 commit into from
Jan 18, 2021
Merged

Refactor #9

merged 1 commit into from
Jan 18, 2021

Conversation

ttrig
Copy link
Contributor

@ttrig ttrig commented Jan 15, 2021 •
edited
Loading

  • Renamed Auditor to Audit.
  • Created a new Auditor class.
  • The facade returns the new Auditor class instead of Audit. This will prevent instances to be re-used.
  • Correlation ID is fetched from Auditor instead of container.
  • Removed AuditorFake (assertions moved to Auditor)

The diff is terrible 😞

@ttrig ttrig force-pushed the refactor branch 2 times, most recently from 899ff74 to d90669c Compare January 15, 2021 12:27
@brother brother removed their request for review January 15, 2021 23:12
@hejhansson hejhansson removed their request for review January 18, 2021 08:21
@ttrig ttrig marked this pull request as ready for review January 18, 2021 09:57
@ttrig ttrig merged commit 1a16a91 into master Jan 18, 2021
@ttrig ttrig deleted the refactor branch January 18, 2021 09:58
This was referenced Jan 18, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christofferlindstrom christofferlindstrom christofferlindstrom approved these changes

@AvvyT AvvyT AvvyT approved these changes

@olyckne olyckne olyckne approved these changes

@wecc wecc wecc approved these changes

@ckarlbe ckarlbe Awaiting requested review from ckarlbe

@emil-nasso emil-nasso Awaiting requested review from emil-nasso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ttrig @wecc @olyckne @AvvyT @christofferlindstrom