Fix clear params on set SQL

glprog · Oct 27, 2019 · 3e47290 · 3e47290
1 parent 8813171
commit 3e47290
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 0 deletions.
diff --git a/MiniREST.SQL.SQLDb.pas b/MiniREST.SQL.SQLDb.pas
@@ -380,6 +380,7 @@ function TMiniRESTSQLQuerySQLDb.GetSQL: string;
 
 procedure TMiniRESTSQLQuerySQLDb.SetSQL(const ASQL: string);
 begin
+  FParams.Clear;
   FSQL := ASQL;
   FQry.SQL.Text := ASQL;
 end;

diff --git a/unittest/SQL/Test.SQL.Default.pas b/unittest/SQL/Test.SQL.Default.pas
@@ -71,6 +71,10 @@   TMiniRESTSQLTest = class({$IFNDEF FPC}TObject{$ELSE}TTestCase{$IFEND})
     [Test]
     {$IFEND}
     procedure TestCheckInTransaction;
+    {$IFNDEF FPC}
+    [Test]
+    {$IFEND}
+    procedure TestClearParamsOnSetSQL;
 (*     {$IFNDEF FPC}
     [Test]
     {$IFEND}
@@ -544,4 +548,28 @@ procedure TMiniRESTSQLTest.TestCheckInTransaction;
   {$IFEND}
 end;
 
+procedure TMiniRESTSQLTest.TestClearParamsOnSetSQL;
+var
+  LConn1: IMiniRESTSQLConnection;
+  LQry: IMiniRESTSQLQuery;
+  LTotal: Integer;
+begin  
+  LConn1 := FConnectionFactory.GetConnection;
+  LQry := LConn1.GetQuery;
+  LQry.SQL := 'SELECT * FROM CUSTOMER WHERE NAME = :NAME';
+  LQry.ParamByName('NAME').AsString := 'HUE';
+  LQry.Open;
+
+  // O teste é assim para verificar se não vai dar erro quando não existir o parâmetro,
+  // passado anteriormente
+  LQry.Close;
+  LQry.SQL := 'SELECT * FROM CUSTOMER';
+  LQry.Open;
+  {$IFNDEF FPC}
+  Assert.AreTrue(LQry.DataSet.Active);
+  {$ELSE}
+  CheckTrue(LQry.DataSet.Active);
+  {$IFEND}
+end;
+
 end.