Skip to content

Commit

Permalink
upstream: clear io_want/io_ready flags at start of poll() cycle;
Browse files Browse the repository at this point in the history
avoids plausible spin during rekeying if channel io_want flags are reused
across cycles. ok markus@ deraadt@

OpenBSD-Commit-ID: 91034f855b7c73cd2591657c49ac30f10322b967
  • Loading branch information
djmdjm committed Apr 11, 2022
1 parent aa19203 commit cd1f700
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions channels.c
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* $OpenBSD: channels.c,v 1.415 2022/03/30 21:10:25 djm Exp $ */
/* $OpenBSD: channels.c,v 1.416 2022/04/11 22:52:08 djm Exp $ */
/*
* Author: Tatu Ylonen <[email protected]>
* Copyright (c) 1995 Tatu Ylonen <[email protected]>, Espoo, Finland
Expand Down Expand Up @@ -2601,7 +2601,12 @@ channel_prepare_poll(struct ssh *ssh, struct pollfd **pfdp, u_int *npfd_allocp,
u_int i, oalloc, p, npfd = npfd_reserved;

channel_before_prepare_io(ssh); /* might create a new channel */

/* clear out I/O flags from last poll */
for (i = 0; i < sc->channels_alloc; i++) {
if (sc->channels[i] == NULL)
continue;
sc->channels[i]->io_want = sc->channels[i]->io_ready = 0;
}
/* Allocate 4x pollfd for each channel (rfd, wfd, efd, sock) */
if (sc->channels_alloc >= (INT_MAX / 4) - npfd_reserved)
fatal_f("too many channels"); /* shouldn't happen */
Expand Down

0 comments on commit cd1f700

Please sign in to comment.