-
Notifications
You must be signed in to change notification settings - Fork 112
added ModernDialog and ModernMessageBox #48
base: master
Are you sure you want to change the base?
Conversation
should be done however the merging of all the changes from the other pull request of hiding window buttons was detected horribly by git, which made this a mess... i could redo this pull request if you want |
I do Squash and Merge while incorperating "single fixes" that can be understood without all git history. Though in this case the changed files looks a bit odd so please create a new PR with the changes. :) |
3ecdd98
to
f215f5f
Compare
okay i have redone this starting with the current origin/master. |
self.on_btnRestore_clicked() | ||
|
||
|
||
class ModernDialog(QDialog): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shares a lot of code with ModernWindow, maybe all of it? I think it would be a good idea to break it into a ModernWidget
which inherits QWidget
that then contains the shared code from ModernWindow and ModernDialog. Window and Dialog can then inherit the ModernWidget
istead of QWidget
.
self.vboxFrame = QVBoxLayout(self.windowFrame) | ||
self.vboxFrame.setContentsMargins(0, 0, 0, 0) | ||
|
||
self.titleBar = TitleBar(self) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def __child_was_closed(self):
on line 306 is never used
Is this project still active? I'd really love to have these features and would implement them myself, but it would take some work to understand the code as the documentation is somewhat scarce. |
ModernDialog is used just like a QDialog.
ModernMessageBox is used just like a QMessageBox
Simple example below