Build Apple Intl with -fobjc-arc

Summary: Clang doesn't enable ARC in Objective-C by default, which means that many of our Obj-C data structures are currently being leaked incorrectly. Reviewed By: jpporto Differential Revision: D38684307 fbshipit-source-id: b31a4c405372de9b9097ef4809f4a217abd5f2b9
gmh5225 · Aug 14, 2022 · 0695878 · 0695878
1 parent 29018f8
commit 0695878
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/lib/Platform/Intl/CMakeLists.txt b/lib/Platform/Intl/CMakeLists.txt
@@ -20,6 +20,7 @@ if(HERMES_ENABLE_INTL)
     )
     # Work around a bug in unity builds where it tries to build Obj-C as C++.
     set_target_properties(hermesPlatformIntl PROPERTIES UNITY_BUILD false)
+    target_compile_options(hermesPlatformIntl PRIVATE -fobjc-arc)
   else()
     add_hermes_library(hermesPlatformIntl STATIC PlatformIntlDummy.cpp LINK_LIBS hermesPublic)
   endif()

diff --git a/lib/Platform/Intl/PlatformIntlApple.mm b/lib/Platform/Intl/PlatformIntlApple.mm
@@ -11,6 +11,8 @@
 #import <Foundation/Foundation.h>
 #include <unordered_set>
 
+static_assert(__has_feature(objc_arc), "arc must be enabled");
+
 namespace hermes {
 namespace platform_intl {
 namespace {