forked from facebook/hermes
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Export public directory from Hermes API targets (facebook#694)
Summary: Pull Request resolved: facebook#694 The headers under the `public` directory are not exported by our API targets, which means that something taking a dependency on those targets won't automatically get the headers. This diff creates a new `hermesPublic` header-only target to get the headers exported correctly. An alternative approach could have been to continue including those headers in our other targets normally, and then only exporting them at the API level. This would be more consistent with how the rest of our build works, since we don't usually rely on include directories exported from targets. However, this approach would have the drawback of being harder to test and maintain, since we don't have testing for which headers are exported from the API level. Reviewed By: jpporto Differential Revision: D34673711 fbshipit-source-id: 5da258ad3ecd7ea72e7c293143f1e5debcfa34a7
- Loading branch information
1 parent
c852306
commit 82cc24d
Showing
8 changed files
with
11 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -161,6 +161,7 @@ set(link_libs | |
hermesSupport | ||
hermesPlatform | ||
hermesInternalBytecode | ||
hermesPublic | ||
dtoa | ||
) | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters