ALSA: usb/6fire: Fix potential NULL pointer dereference in comm.c

'rt' was dereferenced before the NULL check. Moved the code after the check. Signed-off-by: Sachin Kamat <[email protected]> Signed-off-by: Takashi Iwai <[email protected]>
gncemre23 · Nov 21, 2012 · 27b2a22 · 27b2a22
1 parent 6cf9515
commit 27b2a22
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/sound/usb/6fire/comm.c b/sound/usb/6fire/comm.c
@@ -129,12 +129,13 @@ int __devinit usb6fire_comm_init(struct sfire_chip *chip)
 {
 	struct comm_runtime *rt = kzalloc(sizeof(struct comm_runtime),
 			GFP_KERNEL);
-	struct urb *urb = &rt->receiver;
+	struct urb *urb;
 	int ret;
 
 	if (!rt)
 		return -ENOMEM;
 
+	urb = &rt->receiver;
 	rt->serial = 1;
 	rt->chip = chip;
 	usb_init_urb(urb);