Vales Iron farm optimizations and more additions #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added his changes under a section I called "VALES" on CarpetSettings, if you want to merge this changes I should first move them into the according position. Also added "Vales" comment on CarpetCommands which I should also remove Feel free to tell me to remove any addition in case you don't want it. |
|
Uhh normally you would PR one feature at a time, so we can review and decide to accept them individually. But I understand this is now going to be hard to split up. I will review when I get the chance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this changes were not made by me but by Vales, since he doesn't want to push this changes I asked him permission to post this. I will describe what was changed below:
/carpet doorSearchOptimization/carpet doorCheckOptimization/carpet ironFarmAABBOptimization/carpet ironGolemsSwim/carpet villagerQueue/carpet villagerQueueLength/carpet villagerTickingRate/carpet villagersRandomStart/carpet doorDeregistrationTime/log villagerPos/log villages <dynamic|overworld|nether|end>/log golems/log counter all/log portalCaching uncaching/log pathfinding/log/counter/logitems not tracking items that change dimensions/ticktimes <start|stop> [filename]