Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #171 #239

Closed
wants to merge 3 commits into from
Closed

Add #171 #239

wants to merge 3 commits into from

Conversation

jtprichett
Copy link

Add #171: Support for accepted and rejected requests. Currently set to simple counters, serialized into an array that is passed to the Request Manager GUI. Then displayed as text objects.

@jtprichett jtprichett closed this Jul 6, 2017
@jtprichett jtprichett reopened this Jul 6, 2017
@hrj
Copy link
Member

hrj commented Jul 6, 2017

Thanks @JoshuaTPritchett, this is a great start. Few comments:

  • The accepted and rejected counts need to move into the RequestManager button.
  • The counts in the button would need to be updated whenever a request is checked with the RequestManager.
  • You need to sign the CLA (it helps protect your contribution as well as the project).
  • Are you able to see my messages on IRC? If you don't have an IRC bouncer you can join the room via matrix.org. Else, join our gitter channel: https://gitter.im/UprootLabs/gngr

@jtprichett
Copy link
Author

jtprichett commented Jul 6, 2017

@hrj I am not sure what you mean, currently, if a user types www.google.com then it would display all of the accepted requests and all of the rejected requests. This is being displayed after you click on the request manager button. Every time a user makes a new domain request, the counters are reset and updated for the new page.

@hrj
Copy link
Member

hrj commented Jul 6, 2017

This is being displayed after you click on the request manager button.

The goal is to display those numbers before clicking. So I imagine them to be shown on the button itself, not in the dialog.

@hrj
Copy link
Member

hrj commented Dec 2, 2017

@JoshuaTPritchett Thanks for your work. I am sorry I didn't respond earlier. For one, github doesn't notify me when you update the PR, and secondly, I had just joined a new project in July, and forgot to follow up here.

The changes look good and ready to merge.

Would it be possible for you to sign the CLA? If not, I am willing to consider other alternatives such as Developer Certificate of Origin.

@hrj
Copy link
Member

hrj commented Jun 5, 2018

To make contributions easier, we are changing our policy to support Developer Certificate of Origin (DCO) and not requiring a CLA anymore. DCO is becoming the new standard used by many open-source projects including the Linux Kernel and GNOME.

See our Contributing Guide for more info about DCO.

@hrj
Copy link
Member

hrj commented Apr 13, 2021

Thanks @JoshuaTPritchett

But I can't merge without DCO 😢

@hrj hrj closed this Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants