Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #29 #32

Merged
merged 1 commit into from
Aug 1, 2022
Merged

Closes #29 #32

merged 1 commit into from
Aug 1, 2022

Conversation

alebanzas
Copy link
Contributor

What

  • In light theme, the links are not easily recognizable. Adding bold and making the color palette easier to identify.

Refs

@alebanzas alebanzas requested a review from plato-gno July 28, 2022 12:50
Copy link
Contributor

@plato-gno plato-gno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have an alternate solution - to keep with the style guide. why not we add --ifm-link-color: #DD7143 instead to :root?

I'm not huge stickler for design but I think some of the markdown docs were breaking on bold (a couple of headers have links)

// in custom.css
:root {
  --ifm-link-color: #DD7143; <- added one line
  --ifm-color-primary: #133629;
  --ifm-color-primary-dark: #113125;
  --ifm-color-primary-darker: #102e23;
  --ifm-color-primary-darkest: #0d261d;
  --ifm-color-primary-light: #153b2d;
  --ifm-color-primary-lighter: #163e2f;
  --ifm-color-primary-lightest: #194635;
  --ifm-code-font-size: 95%;
  --docusaurus-highlighted-code-line-bg: rgba(0, 0, 0, 0.1);
}

image

@alebanzas
Copy link
Contributor Author

alebanzas commented Jul 29, 2022

According to the docusaurus docs we should change all the --ifm- variables.

I agree on not making it bold is a better solution. The orange is the one I put in the dark theme, it could go well with the light theme also, but it does not pass the Contrast Rating

@plato-gno
Copy link
Contributor

Merging this first and we can fix it later on

Copy link
Contributor

@plato-gno plato-gno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@plato-gno plato-gno merged commit 4e40364 into main Aug 1, 2022
@alebanzas alebanzas deleted the 29-linka branch August 1, 2022 11:30
@alebanzas alebanzas mentioned this pull request Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants