Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only run test coverage on master branch. #1838

Merged
merged 8 commits into from
Jun 1, 2017
Merged

fix: only run test coverage on master branch. #1838

merged 8 commits into from
Jun 1, 2017

Conversation

appleboy
Copy link
Member

As @tboerger mention #1783 (comment). drone-coverage plugin doesn't support command attribute so we change test command behavior. Just run test coverage on the master branch.

cc @tboerger @lunny @bkcsoft

@appleboy appleboy added the type/enhancement An improvement of existing functionality label May 31, 2017
@appleboy appleboy added this to the 1.2.0 milestone May 31, 2017
@appleboy
Copy link
Member Author

cc @ethantkoenig and need @lunny resign the drone sig file.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 31, 2017
@lunny
Copy link
Member

lunny commented May 31, 2017

@appleboy I think you already had resign drone permission.

appleboy added 3 commits May 31, 2017 16:10
@appleboy
update test command.
cf2735a 
Signed-off-by: Bo-Yi Wu <[email protected]>
@appleboy
update drone
823574a 
Signed-off-by: Bo-Yi Wu <[email protected]>
@appleboy
update drone
94a27a8 
Signed-off-by: Bo-Yi Wu <[email protected]>
@appleboy appleboy changed the title fix: only run test coverage on master branch. [WIP] fix: only run test coverage on master branch. May 31, 2017
appleboy added 2 commits May 31, 2017 16:28
@appleboy
update drone
7d79e1d 
Signed-off-by: Bo-Yi Wu <[email protected]>
@appleboy
update drone
0a9ed3e 
Signed-off-by: Bo-Yi Wu <[email protected]>
@appleboy appleboy changed the title [WIP] fix: only run test coverage on master branch. fix: only run test coverage on master branch. May 31, 2017
@appleboy
Copy link
Member Author

@tboerger @lunny Done. Please help to review.

@ethantkoenig
Copy link
Member

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 31, 2017
@bkcsoft
Copy link
Member

bkcsoft commented Jun 1, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 1, 2017
@bkcsoft bkcsoft merged commit 04c6c31 into go-gitea:master Jun 1, 2017
@appleboy appleboy deleted the drone123 branch June 2, 2017 01:11
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@appleboy @lunny @ethantkoenig @bkcsoft @tboerger