Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional func to init Store #4

Merged
merged 2 commits into from
Mar 13, 2022

Conversation

vinhha96
Copy link

@vinhha96 vinhha96 commented Mar 13, 2022

Propose

Hi @LyricTian ,
Based on this issue, I have a problem when init Store with the engine of Dabasase is InnoDB (because I use CloudSQL, and CloudSQL only supports InnoDB Engine). So, I can't use this library to init Store.

I had opened this PR to custom function init Store more flexible with Optional function, we can custom parameter to init Store. If not, this package will be inited with the default config.

And I had refactored code to make sure my changes do not break current logic.

Hopefully, the author will review and accepted this PR.

Changes

  • Add option function to init Store
  • Add unit test with my changes
  • Update go mod to version go.1.17

Checklist

  • Unit test pass on my locally

@LyricTian LyricTian merged commit 0a2eae8 into go-oauth2:master Mar 13, 2022
@vinhha96 vinhha96 deleted the feature/apply-option-func branch March 13, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants