Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Go 1.24 to the test matrix #1681

Merged
merged 4 commits into from
Apr 8, 2025
Merged

add Go 1.24 to the test matrix #1681

merged 4 commits into from
Apr 8, 2025

Conversation

shogo82148
Copy link
Contributor

@shogo82148 shogo82148 commented Mar 9, 2025

Description

add Go 1.24 to the test matrix.

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

Summary by CodeRabbit

  • Chores
    • Updated the compatibility and testing configuration to prioritize the latest Go release while retaining support for previous production releases.
  • Documentation
    • Revised the minimum required Go version to 1.22 to ensure current language standards are met.

Copy link

coderabbitai bot commented Mar 9, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request updates the Go version configurations across the project. The GitHub Actions workflow now prioritizes Go 1.24 as the most recent production release, while retaining 1.23 for compatibility testing and removing 1.21. Additionally, the README now specifies a minimum requirement of Go 1.22, and the go.mod file reflects this update by changing the Go version from 1.21.0 to 1.22.0. There are no changes to any exported or public entities.

Changes

File(s) Change Summary
.github/workflows/test.yml Updated Go version list: replaced top '1.23' with '1.24', reintroduced '1.23' as an older release, and removed '1.21'.
README.md, go.mod Revised Go version requirements: updated README from "Go 1.21 or higher" to "Go 1.22 or higher" and changed go.mod from 1.21.0 to 1.22.0.

Sequence Diagram(s)

sequenceDiagram
    participant C as Commit
    participant GA as GitHub Actions
    participant M as Matrix Generator
    participant TJ as Test Runner

    C->>GA: Trigger CI workflow
    GA->>M: Generate test matrix with Go versions (1.24, 1.23)
    M->>TJ: Run tests for each Go version
    TJ-->>GA: Report test results
Loading

Possibly related PRs

Suggested reviewers

  • methane

Poem

I'm a little rabbit hopping in the code,
Changing Go versions on my bouncy road.
1.24 marches ahead with a vibrant gleam,
While 1.23 nods quietly in the testing stream.
Together we hop toward a flawless dream!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 21ef4c6 and 09f335f.

📒 Files selected for processing (3)
  • .github/workflows/test.yml (1 hunks)
  • README.md (1 hunks)
  • go.mod (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@coveralls
Copy link

coveralls commented Mar 9, 2025

Coverage Status

coverage: 82.857% (-0.1%) from 82.959%
when pulling 09f335f on go1.24-is-released
into 21ef4c6 on master.

@methane
Copy link
Member

methane commented Mar 10, 2025

I will release v1.9.1 soon from master branch.
Please drop go1.21 after it.

@methane
Copy link
Member

methane commented Apr 7, 2025

I have created 1.9 branch.
master branch is now for 1.10. Let's go.

@shogo82148 shogo82148 requested a review from methane April 8, 2025 00:03
@shogo82148 shogo82148 marked this pull request as ready for review April 8, 2025 03:45
@shogo82148 shogo82148 merged commit c84f49d into master Apr 8, 2025
73 checks passed
@shogo82148 shogo82148 deleted the go1.24-is-released branch April 8, 2025 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants