Fix TIME format for binary columns #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
methane
force-pushed
the
fix-formatBinaryTime
branch
from
ee43fdd to
dc3665b
Compare
methane
force-pushed
the
fix-formatBinaryTime
branch
from
dc3665b to
f09c12c
Compare
methane
changed the title
|
This should definitely have some sort of (regression) test |
methane
commented
Jun 12, 2018
| expect("12:34:56.00", []byte{0, 0, 0, 0, 0, 12, 34, 56}, 11) | ||
| expect("24:34:56", []byte{0, 1, 0, 0, 0, 0, 34, 56}, 8) | ||
| expect("-99:34:56", []byte{1, 4, 0, 0, 0, 3, 34, 56}, 8) | ||
| expect("103079215103:34:56", []byte{0, 255, 255, 255, 255, 23, 34, 56}, 8) |
There was a problem hiding this comment.
These three inputs are regression test.
There was a problem hiding this comment.
Oh, sorry. I missed the changes in this file
julienschmidt
approved these changes
Jun 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #817
Description
Split formatBinaryDateTime and formatBinaryTime
Checklist